[I] Render the version list's collapse and selection rules [texera]

["aglinxinyuan (via GitHub)" <gi...@apache.org>]

aglinxinyuan opened a new issue, #7404:
URL: https://github.com/apache/texera/issues/7404

   ### Task Summary
   
   `VersionsListComponent` keeps its display rules in the template, and none of them are rendered by the spec — the existing tests drive `collapse()` and `getDisplayedVersionId()` directly. Locally the template sits at roughly 4% of statements.
   
   The rule worth pinning is the row predicate:
   
   ```html
   <tr *ngIf="(!row.importance && row.expand) || row.importance">
   ```
   
   A minor version stays folded away until its important parent is expanded — that is the entire point of the collapse, and it lives only in the template. Alongside it: the descending version number from `getDisplayedVersionId(i, l)`, the `selected-row` highlight keyed to `selectedRowIndex === i`, `[nzShowExpand]="row.importance"` so only important versions get an expand control, the three arguments the timestamp button hands to `getVersion`, the `MM/dd/yy HH:mm:ss` date format, and `*ngIf="versionsList"` hiding the table until versions load.
   
   The spec is already set up for this — it deliberately skips `detectChanges()` in `beforeEach` and notes that "tests that need the rendered template call detectChanges() locally".
   
   One gotcha: `nz-table` renders its own expand-icon `<button>`, so `querySelector("button")` finds that rather than the version link. Select `button.version-link`.
   
   ### Task Type
   
   - [ ] Refactor / Cleanup
   - [ ] DevOps / Deployment / CI
   - [x] Testing / QA
   - [ ] Documentation
   - [ ] Performance
   - [ ] Other
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Render the version list's collapse and selection rules [texera]

["aglinxinyuan (via GitHub)" <gi...@apache.org>]

aglinxinyuan closed issue #7404: Render the version list's collapse and selection rules
URL: https://github.com/apache/texera/issues/7404


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Render the version list's collapse and selection rules [texera]

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on issue #7404:
URL: https://github.com/apache/texera/issues/7404#issuecomment-5223750260

   <!-- texera:template-compliance -->
   👋 Thanks for opening this issue, @aglinxinyuan!
   
   It looks like the issue description doesn't quite follow our template yet:
   
   - This issue doesn't appear to use one of our templates (Bug, Feature, or Task). Please open it using a template so the required details are captured.
   
   Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
   
   You can find the template prompts by editing the description, or see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) for the full contribution flow.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org