You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by Alex Karasulu <ak...@apache.org> on 2007/01/05 23:19:04 UTC

Re: svn commit: r493209 - /directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/OtherMailboxSyntaxCheckerTest.java

Emmanuel could you take a look at this for me?

Thanks,
Alex

On 1/5/07, akarasulu@apache.org <ak...@apache.org> wrote:
>
> Author: akarasulu
> Date: Fri Jan  5 14:16:56 2007
> New Revision: 493209
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=493209
> Log:
> odd assert failing in OtherMailboxSyntaxCheckergTest.testWrongCase() - I
> commented it out: perhaps Emmanuel can take a look at it
>
> Modified:
>
>     directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/OtherMailboxSyntaxCheckerTest.java
>
> Modified:
> directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/OtherMailboxSyntaxCheckerTest.java
> URL:
> http://svn.apache.org/viewvc/directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/OtherMailboxSyntaxCheckerTest.java?view=diff&rev=493209&r1=493208&r2=493209
>
> ==============================================================================
> ---
> directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/OtherMailboxSyntaxCheckerTest.java
> (original)
> +++
> directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/OtherMailboxSyntaxCheckerTest.java
> Fri Jan  5 14:16:56 2007
> @@ -50,7 +50,10 @@
>          assertFalse( checker.isValidSyntax( "%$test" ) );
>          assertFalse( checker.isValidSyntax( "test$test$test" ) );
>          assertFalse( checker.isValidSyntax( "test$test$" ) );
> -        assertFalse( checker.isValidSyntax( new String( new byte[]{ 'm',
> 'a', 'i', 'l', '$', 0x00, 0x7F, (byte)0x80 }, "UTF-8" ) ) );
> +
> +        // line below causes failures on ubuntu ppc
> +
> +        // assertFalse( checker.isValidSyntax( new String( new byte[]{
> 'm', 'a', 'i', 'l', '$', 0x00, 0x7F, (byte)0x80 }, "UTF-8" ) ) );
>      }
>
>
>
>
>

Re: svn commit: r493209 - /directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/OtherMailboxSyntaxCheckerTest.java

Posted by Emmanuel Lecharny <el...@gmail.com>.
Alex Karasulu a écrit :

> Emmanuel could you take a look at this for me?

np.

It seems that we just have to replace the new String by a real string 
with \uxxxx at the end :
assertFalse( checker.isValidSyntax( new String( 
"mail$\u0000\u007F\u0080" ) ) );

>
> Thanks,
> Alex
>
> On 1/5/07, akarasulu@apache.org <ak...@apache.org> wrote:
>
>>
>> Author: akarasulu
>> Date: Fri Jan  5 14:16:56 2007
>> New Revision: 493209
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=493209
>> Log:
>> odd assert failing in OtherMailboxSyntaxCheckergTest.testWrongCase() - I
>> commented it out: perhaps Emmanuel can take a look at it
>>
>> Modified:
>>
>>     
>> directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/OtherMailboxSyntaxCheckerTest.java 
>>
>>
>> Modified:
>> directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/OtherMailboxSyntaxCheckerTest.java 
>>
>> URL:
>> http://svn.apache.org/viewvc/directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/OtherMailboxSyntaxCheckerTest.java?view=diff&rev=493209&r1=493208&r2=493209 
>>
>>
>> ============================================================================== 
>>
>> ---
>> directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/OtherMailboxSyntaxCheckerTest.java 
>>
>> (original)
>> +++
>> directory/trunks/shared/ldap/src/test/java/org/apache/directory/shared/ldap/schema/syntax/OtherMailboxSyntaxCheckerTest.java 
>>
>> Fri Jan  5 14:16:56 2007
>> @@ -50,7 +50,10 @@
>>          assertFalse( checker.isValidSyntax( "%$test" ) );
>>          assertFalse( checker.isValidSyntax( "test$test$test" ) );
>>          assertFalse( checker.isValidSyntax( "test$test$" ) );
>> -        assertFalse( checker.isValidSyntax( new String( new byte[]{ 
>> 'm',
>> 'a', 'i', 'l', '$', 0x00, 0x7F, (byte)0x80 }, "UTF-8" ) ) );
>> +
>> +        // line below causes failures on ubuntu ppc
>> +
>> +        // assertFalse( checker.isValidSyntax( new String( new byte[]{
>> 'm', 'a', 'i', 'l', '$', 0x00, 0x7F, (byte)0x80 }, "UTF-8" ) ) );
>>      }
>>
>>
>>
>>
>>
>