You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Zakelly (via GitHub)" <gi...@apache.org> on 2024/07/10 10:32:20 UTC

[PR] [FLINK-35803][checkpoint] Fix the wrong file reuse in cp file-merging [flink]

Zakelly opened a new pull request, #25069:
URL: https://github.com/apache/flink/pull/25069

   ## What is the purpose of the change
   
   There is an issue of reusing wrong restored files in following cp when enabling file-merging. All the files from previous job should not be reused afterwards. This PR fixes that.
   
   
   ## Brief change log
   
    - When creating/referencing a `PhysicalFile` during recovery, mark it unable to reuse.
   
   
   ## Verifying this change
   
   This change is already covered by existing IT tests, such as `ResumeCheckpointManuallyITCase`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-35803][checkpoint] Fix the wrong file reuse in cp file-merging [flink]

Posted by "fredia (via GitHub)" <gi...@apache.org>.
fredia commented on PR #25069:
URL: https://github.com/apache/flink/pull/25069#issuecomment-2220407244

   Thanks for the PR, `couldReuse` does have a problem, the fix is LGTM.
   
   But for the failed test `testSwitchFromEnablingToDisablingFileMerging`, the check fail at 3rd checkpoint, I think it has something to do with the test itself.
   
   When restoring a job from `file-merging disabled` to  `file-merging disabled` in CLAIM mode, the restored state handle may be reused by the subsequent checkpoint, it is uncertain when the restored files will actually be deleted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-35803][checkpoint] Fix the wrong file reuse in cp file-merging [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #25069:
URL: https://github.com/apache/flink/pull/25069#issuecomment-2220196791

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c9c1af690dfd791e5856799f1344562f946a5d59",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c9c1af690dfd791e5856799f1344562f946a5d59",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c9c1af690dfd791e5856799f1344562f946a5d59 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-35803][checkpoint] Fix the wrong file reuse in cp file-merging [flink]

Posted by "Zakelly (via GitHub)" <gi...@apache.org>.
Zakelly merged PR #25069:
URL: https://github.com/apache/flink/pull/25069


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org