Re: [PR] feat(prometheus): Add native /metrics endpoint [activemq]

["hai-ben (via GitHub)" <gi...@apache.org>]

hai-ben commented on PR #2402:
URL: https://github.com/apache/activemq/pull/2402#issuecomment-6013957905

   Thanks @mattrpav and @jbonofre 
   
   I've updated with your feedback with a couple small deviations:
   
   > Add serious input validation (null check, length, regex, etc) and input value escaping before passing the object names to JMX queries.
   
   The design now obsoletes this, it just uses the existing helpers. So the only point a user gets to choose something is in the config about which destination types are used and whether or not they want per-destination metrics.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact