You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by GitBox <gi...@apache.org> on 2020/04/07 22:53:08 UTC

[GitHub] [arrow-site] nealrichardson opened a new pull request #52: ARROW-4482: [Website] Add blog archive page

nealrichardson opened a new pull request #52: ARROW-4482: [Website] Add blog archive page
URL: https://github.com/apache/arrow-site/pull/52
 
 
   The /blog/ page now looks like this:
   
   ![image](https://user-images.githubusercontent.com/2975928/78726737-96bd7a80-78e7-11ea-976c-9bd2efa39e60.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [arrow-site] wesm commented on a change in pull request #52: ARROW-4482: [Website] Add blog archive page

Posted by GitBox <gi...@apache.org>.
wesm commented on a change in pull request #52: ARROW-4482: [Website] Add blog archive page
URL: https://github.com/apache/arrow-site/pull/52#discussion_r405192334
 
 

 ##########
 File path: blog.html
 ##########
 @@ -26,6 +26,16 @@ <h2>Project News and Blog</h2>
 
 {% for post in site.posts %}
   {% unless post.categories contains 'translation' %}
-    {% include blog_entry.html %}
+  <p>
+    <h3>
+      <a href="{{ site.baseurl }}{{ post.url }}">{{ post.title }}</a>
+    </h3>
+    <p>
+    <span class="blog-list-date">
+      {{ post.date | date: "%-d %B %Y" }}
+    </span>
 
 Review comment:
   What do you think about adding the author here also? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [arrow-site] wesm closed pull request #52: ARROW-4482: [Website] Add blog archive page

Posted by GitBox <gi...@apache.org>.
wesm closed pull request #52: ARROW-4482: [Website] Add blog archive page
URL: https://github.com/apache/arrow-site/pull/52
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [arrow-site] nealrichardson commented on a change in pull request #52: ARROW-4482: [Website] Add blog archive page

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #52: ARROW-4482: [Website] Add blog archive page
URL: https://github.com/apache/arrow-site/pull/52#discussion_r405612891
 
 

 ##########
 File path: blog.html
 ##########
 @@ -26,6 +26,16 @@ <h2>Project News and Blog</h2>
 
 {% for post in site.posts %}
   {% unless post.categories contains 'translation' %}
-    {% include blog_entry.html %}
+  <p>
+    <h3>
+      <a href="{{ site.baseurl }}{{ post.url }}">{{ post.title }}</a>
+    </h3>
+    <p>
+    <span class="blog-list-date">
+      {{ post.date | date: "%-d %B %Y" }}
+    </span>
 
 Review comment:
   I tried it and preferred how it looked without. Most say "The Apache Arrow PMC (pmc)" so it seemed like noise.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [arrow-site] wesm commented on issue #52: ARROW-4482: [Website] Add blog archive page

Posted by GitBox <gi...@apache.org>.
wesm commented on issue #52: ARROW-4482: [Website] Add blog archive page
URL: https://github.com/apache/arrow-site/pull/52#issuecomment-610660164
 
 
   Oh this is so good, thank you

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [arrow-site] nealrichardson commented on issue #52: ARROW-4482: [Website] Add blog archive page

Posted by GitBox <gi...@apache.org>.
nealrichardson commented on issue #52: ARROW-4482: [Website] Add blog archive page
URL: https://github.com/apache/arrow-site/pull/52#issuecomment-611063108
 
 
   I added the translation information as metadata, so the list looks like this now:
   
   ![image](https://user-images.githubusercontent.com/2975928/78809866-67a51880-797c-11ea-9589-49b952aa6ed7.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services