You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/06/18 01:32:59 UTC
Review Request 22702: Updated mesos to use the new Subprocess API.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22702/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1487
https://issues.apache.org/jira/browse/MESOS-1487
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/launcher/launcher.cpp 1d352b6
src/linux/perf.cpp bc31db5
src/slave/containerizer/external_containerizer.cpp b5d0c4c
src/slave/containerizer/mesos_containerizer.cpp 4d97d49
src/tests/slave_tests.cpp 9178e01
Diff: https://reviews.apache.org/r/22702/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 22702: Updated mesos to use the new Subprocess API.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22702/#review46052
-----------------------------------------------------------
Patch looks great!
Reviews applied: [22688, 22702]
All tests passed.
- Mesos ReviewBot
On June 17, 2014, 11:32 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22702/
> -----------------------------------------------------------
>
> (Updated June 17, 2014, 11:32 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1487
> https://issues.apache.org/jira/browse/MESOS-1487
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/launcher.cpp 1d352b6
> src/linux/perf.cpp bc31db5
> src/slave/containerizer/external_containerizer.cpp b5d0c4c
> src/slave/containerizer/mesos_containerizer.cpp 4d97d49
> src/tests/slave_tests.cpp 9178e01
>
> Diff: https://reviews.apache.org/r/22702/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 22702: Updated mesos to use the new Subprocess API.
Posted by Jie Yu <yu...@gmail.com>.
> On June 18, 2014, 5:07 p.m., Benjamin Hindman wrote:
> > src/launcher/launcher.cpp, lines 212-213
> > <https://reviews.apache.org/r/22702/diff/1/?file=611937#file611937line212>
> >
> > Why not:
> >
> > Subprocess::FD(stdout),
> > Subprocess::FD(stderr),
> >
> > Then kill the io::redirect below?
I am currently refactoring the Launcher/Operation interfaces. This interface is gonna change soon. So I am dropping it:)
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22702/#review46095
-----------------------------------------------------------
On June 17, 2014, 11:32 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22702/
> -----------------------------------------------------------
>
> (Updated June 17, 2014, 11:32 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1487
> https://issues.apache.org/jira/browse/MESOS-1487
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/launcher.cpp 1d352b6
> src/linux/perf.cpp bc31db5
> src/slave/containerizer/external_containerizer.cpp b5d0c4c
> src/slave/containerizer/mesos_containerizer.cpp 4d97d49
> src/tests/slave_tests.cpp 9178e01
>
> Diff: https://reviews.apache.org/r/22702/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 22702: Updated mesos to use the new Subprocess API.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On June 18, 2014, 5:07 p.m., Benjamin Hindman wrote:
> > src/launcher/launcher.cpp, lines 212-213
> > <https://reviews.apache.org/r/22702/diff/1/?file=611937#file611937line212>
> >
> > Why not:
> >
> > Subprocess::FD(stdout),
> > Subprocess::FD(stderr),
> >
> > Then kill the io::redirect below?
>
> Jie Yu wrote:
> I am currently refactoring the Launcher/Operation interfaces. This interface is gonna change soon. So I am dropping it:)
SGTM! Thanks for following up!
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22702/#review46095
-----------------------------------------------------------
On June 17, 2014, 11:32 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22702/
> -----------------------------------------------------------
>
> (Updated June 17, 2014, 11:32 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1487
> https://issues.apache.org/jira/browse/MESOS-1487
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/launcher.cpp 1d352b6
> src/linux/perf.cpp bc31db5
> src/slave/containerizer/external_containerizer.cpp b5d0c4c
> src/slave/containerizer/mesos_containerizer.cpp 4d97d49
> src/tests/slave_tests.cpp 9178e01
>
> Diff: https://reviews.apache.org/r/22702/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 22702: Updated mesos to use the new Subprocess API.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22702/#review46095
-----------------------------------------------------------
Ship it!
It's clear that there are other opportunities to just use Subprocess::PATH too (for example with the fetch code), but that would require some slight cleanup around doing 'chown' (or moving that functionality to Subprocess too).
src/launcher/launcher.cpp
<https://reviews.apache.org/r/22702/#comment81250>
Why not:
Subprocess::FD(stdout),
Subprocess::FD(stderr),
Then kill the io::redirect below?
- Benjamin Hindman
On June 17, 2014, 11:32 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22702/
> -----------------------------------------------------------
>
> (Updated June 17, 2014, 11:32 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1487
> https://issues.apache.org/jira/browse/MESOS-1487
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/launcher.cpp 1d352b6
> src/linux/perf.cpp bc31db5
> src/slave/containerizer/external_containerizer.cpp b5d0c4c
> src/slave/containerizer/mesos_containerizer.cpp 4d97d49
> src/tests/slave_tests.cpp 9178e01
>
> Diff: https://reviews.apache.org/r/22702/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>