You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "anujphadke (Code Review)" <ge...@cloudera.org> on 2016/06/10 23:29:46 UTC
[Impala-CR](cdh5-trunk) IMPALA-3342: Runtime profile TotalCpuTime should eliminate wait times
anujphadke has uploaded a new change for review.
http://gerrit.cloudera.org:8080/3369
Change subject: IMPALA-3342: Runtime profile TotalCpuTime should eliminate wait times
......................................................................
IMPALA-3342: Runtime profile TotalCpuTime should eliminate wait times
Impala uses the wall clock timer to measure the CPU time from the thread
start to finish. This also accounts for all the time when a thread gets
pre-empted or blocked. This change adds the CLOCK_THREAD_CPUTIME_ID timer to
measure the CPU time spent in execution only.
Change-Id: If8edd0c3559968ff12e42f83dd970e424fa4a3c8
---
M be/src/util/runtime-profile-counters.h
M be/src/util/stopwatch.h
2 files changed, 25 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/69/3369/1
--
To view, visit http://gerrit.cloudera.org:8080/3369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If8edd0c3559968ff12e42f83dd970e424fa4a3c8
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: anujphadke <ap...@cloudera.com>
[Impala-CR](cdh5-trunk) IMPALA-3342: Runtime profile TotalCpuTime should eliminate wait times
Posted by "anujphadke (Code Review)" <ge...@cloudera.org>.
anujphadke has posted comments on this change.
Change subject: IMPALA-3342: Runtime profile TotalCpuTime should eliminate wait times
......................................................................
Patch Set 1:
I am not sure if this change is really needed. Looks like we already print the Systime and the threadUserTime information obtained from getrusage() in the profile. I will run a few tests and verify if the values returned by the new timer and getrusage match.
--
To view, visit http://gerrit.cloudera.org:8080/3369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8edd0c3559968ff12e42f83dd970e424fa4a3c8
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: anujphadke <ap...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3342: Runtime profile TotalCpuTime should eliminate wait times
Posted by "anujphadke (Code Review)" <ge...@cloudera.org>.
anujphadke has posted comments on this change.
Change subject: IMPALA-3342: Runtime profile TotalCpuTime should eliminate wait times
......................................................................
Patch Set 1:
The results looked imilar.
Moved the review here
https://gerrit.cloudera.org/#/c/4052/
--
To view, visit http://gerrit.cloudera.org:8080/3369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8edd0c3559968ff12e42f83dd970e424fa4a3c8
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: anujphadke <ap...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3342: Runtime profile TotalCpuTime should eliminate wait times
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3342: Runtime profile TotalCpuTime should eliminate wait times
......................................................................
Patch Set 1:
Anuj, did you run those tests? What was the outcome?
--
To view, visit http://gerrit.cloudera.org:8080/3369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If8edd0c3559968ff12e42f83dd970e424fa4a3c8
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: anujphadke <ap...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-HasComments: No
[Impala-CR](cdh5-trunk) IMPALA-3342: Runtime profile TotalCpuTime should eliminate wait times
Posted by "anujphadke (Code Review)" <ge...@cloudera.org>.
anujphadke has abandoned this change.
Change subject: IMPALA-3342: Runtime profile TotalCpuTime should eliminate wait times
......................................................................
Abandoned
Code review moved here.
https://gerrit.cloudera.org/#/c/4052/
--
To view, visit http://gerrit.cloudera.org:8080/3369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: If8edd0c3559968ff12e42f83dd970e424fa4a3c8
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: anujphadke <ap...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>