You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lenya.apache.org by "Linczak, Jonathan W." <Li...@hiram.edu> on 2005/04/24 01:13:18 UTC
Sitetree addition for redirect URL
Hi all,
I posted here a little bit ago about just adding another attribute to a node in the sitetree for redirecting URLs since everyone has been finding it tough to come up with a good solution. Well, I decided to take on the coding myself, and I am happy to say that I actually have something that's working. It's not perfect, but at least it is working.
I've made changes to many files to make this happen, and I don't have Eclipse or anything to create a patch, and with 1.2.3 coming out soon, I don't know how much has changed in the files that I changed. So, the question is: how should I submit my enhancement bug? Should I list out all the changes I made? Or attach updated files from the 1.2.2 release and have someone else integrate the changes in?
I could also use someone's expertise in finishing up my code. Here's what I have it doing so far:
1. When you go to add a new document, there's a new prompt for redirect URL that can be left blank if not needed.
2. If you add a redirect URL, the node is added in the sitetree with an attribute redirecturl="http://www.someplace.com/", for example.
3. I then changed the sitetree2nav.xsl and menu.xsl files so that in the Authoring and Live environments, the link in the nav is the redirectURL instead of the href URL if that attribute exists in that node.
Here are the problems:
1. Since the redirect URL shows up in the Authoring tab, I can't click on it unless I am in the Site tab. I would think it might be better to have the document ID used for the Authoring tab, but the redirect URL used for the Live tab. WDYT?
2. I added an item in the overview section in the Site tab for redirect URL, but nothing is being displayed. Not sure what I am missing there.
3. Should probably put together a task to change the redirect URL as we do for the node visibility, changing of the URL, etc.
I think that's it. What do you guys think? Anyone willing to help me understand how to do this stuff or take over what I have so far?
Jon
Re: (making patch)
Posted by "Gregor J. Rothfuss" <gr...@apache.org>.
qMax wrote:
> Sunday, April 24, 2005, 6:44:41 AM, gregor@apache.org wrote:
> GJR> the best way forward is to teach you how to use eclipse so that you can
> GJR> keep up to date with developments, and create patches easily.
> isn't svn diff enough ?
> (I'm going to commit my LDAP code)
ultimately, that's what eclipse does, of course.
beautifully explained here http://osteele.com/archives/2004/11/ides
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
(making patch)
Posted by qMax <qm...@mediasoft.ru>.
Sunday, April 24, 2005, 6:44:41 AM, gregor@apache.org wrote:
GJR> the best way forward is to teach you how to use eclipse so that you can
GJR> keep up to date with developments, and create patches easily.
isn't svn diff enough ?
(I'm going to commit my LDAP code)
--
qMax
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
Re: Sitetree addition for redirect URL
Posted by Hubertus Groepper <hu...@groepper.com>.
Am 24.04.2005 um 01:44 schrieb Gregor J. Rothfuss:
> Linczak, Jonathan W. wrote:
>
>> I think that's it. What do you guys think? Anyone willing to help
>> me understand how to do this stuff or take over what I have so far?
>
> the best way forward is to teach you how to use eclipse so that you
> can keep up to date with developments, and create patches easily.
For a quick shot, snv diff on the changed files may suffice, as
described here: http://cocoon.apache.org/2.1/howto/howto-patch.html
hubertus
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
Re: Sitetree addition for redirect URL
Posted by "Gregor J. Rothfuss" <gr...@apache.org>.
Linczak, Jonathan W. wrote:
> I think that's it. What do you guys think? Anyone willing to help me understand how to do this stuff or take over what I have so far?
the best way forward is to teach you how to use eclipse so that you can
keep up to date with developments, and create patches easily.
deriving patches from files is a lot of work, which is better spent on
making you more productive ;)
catch me on irc or im some time and i'll show you how.
-gregor
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org