You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2015/11/13 12:17:52 UTC

[GitHub] incubator-zeppelin pull request: ZEPPELIN-418 Keep paragraph heigh...

GitHub user Leemoonsoo opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/426

    ZEPPELIN-418 Keep paragraph height the same with/without executionTime label

    Addresses https://issues.apache.org/jira/browse/ZEPPELIN-418.
    
    * [x] executionTime label ("took xx seconds") keeps it's space while paragraph is running
    * [x] show executionTime label only on hover mouse in 'simple' look n feel
    
    #### 'default' look n feel
    
    Before
    ![image](https://cloud.githubusercontent.com/assets/1540981/11144800/d92565ba-8a42-11e5-9948-ec1dce8afb2a.png)
    
    
    After
    ![image](https://cloud.githubusercontent.com/assets/1540981/11144767/988a2342-8a42-11e5-889f-988a3d3aefcb.png)
    
    
    #### 'simple' look n feel
    
    Before
    
    ![image](https://cloud.githubusercontent.com/assets/1540981/11144821/06c38510-8a43-11e5-9839-843861c97edd.png)
    
    After
    
    ![image](https://cloud.githubusercontent.com/assets/1540981/11144834/27c86d84-8a43-11e5-9214-936cff901abe.png)
    
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Leemoonsoo/incubator-zeppelin fixed_height

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/426.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #426
    
----
commit 974e6137eb4c77b1046c77f9b358ae24126b27f4
Author: Lee moon soo <mo...@apache.org>
Date:   2015-11-13T09:38:46Z

    Keep paragraph height the same with/without scrollbar (and executionTime)

commit c040c5c1050849fa79990faf2313eb4e2b956d51
Author: Lee moon soo <mo...@apache.org>
Date:   2015-11-13T11:11:58Z

    botton-margin

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-418 Keep paragraph heigh...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/426


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-418 Keep paragraph heigh...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/426#issuecomment-157566950
  
    Thanks, I'm merging it into master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-418 Keep paragraph heigh...

Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/426#issuecomment-157452053
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-418 Keep paragraph heigh...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/426#issuecomment-156775339
  
    looks good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: ZEPPELIN-418 Keep paragraph heigh...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/426#issuecomment-156401401
  
    Ready to merge. Please review it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---