You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "Tim Halloran (JIRA)" <ji...@apache.org> on 2012/11/14 19:24:12 UTC
[jira] [Created] (ACCUMULO-855) Patch to remove acquisition of
redundant lock: LiveTServerSet in org.apache.accumulo.server.master
Tim Halloran created ACCUMULO-855:
-------------------------------------
Summary: Patch to remove acquisition of redundant lock: LiveTServerSet in org.apache.accumulo.server.master
Key: ACCUMULO-855
URL: https://issues.apache.org/jira/browse/ACCUMULO-855
Project: Accumulo
Issue Type: Improvement
Reporter: Tim Halloran
Priority: Minor
A lock on the receiver is acquired twice by this method. This has two drawbacks (a) it slows performance and (b) is confusing.
A patch is attached proposing the fix -- I left the method synchronized and removed the lock acquisition in the method to match the other methods in the class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (ACCUMULO-855) Patch to remove acquisition of
redundant lock: LiveTServerSet in org.apache.accumulo.server.master
Posted by "Billie Rinaldi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Billie Rinaldi reassigned ACCUMULO-855:
---------------------------------------
Assignee: Tim Halloran
Tim, thanks for the patch! We've added you to our contributors group in JIRA.
> Patch to remove acquisition of redundant lock: LiveTServerSet in org.apache.accumulo.server.master
> --------------------------------------------------------------------------------------------------
>
> Key: ACCUMULO-855
> URL: https://issues.apache.org/jira/browse/ACCUMULO-855
> Project: Accumulo
> Issue Type: Improvement
> Reporter: Tim Halloran
> Assignee: Tim Halloran
> Priority: Minor
> Fix For: 1.5.0
>
> Attachments: LiveTServerSet.java.patch
>
>
> A lock on the receiver is acquired twice by this method. This has two drawbacks (a) it slows performance and (b) is confusing.
> A patch is attached proposing the fix -- I left the method synchronized and removed the lock acquisition in the method to match the other methods in the class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (ACCUMULO-855) Patch to remove acquisition of
redundant lock: LiveTServerSet in org.apache.accumulo.server.master
Posted by "Eric Newton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Newton resolved ACCUMULO-855.
----------------------------------
Resolution: Fixed
Fix Version/s: 1.5.0
patch applied with r1409288. Nice catch.
> Patch to remove acquisition of redundant lock: LiveTServerSet in org.apache.accumulo.server.master
> --------------------------------------------------------------------------------------------------
>
> Key: ACCUMULO-855
> URL: https://issues.apache.org/jira/browse/ACCUMULO-855
> Project: Accumulo
> Issue Type: Improvement
> Reporter: Tim Halloran
> Priority: Minor
> Fix For: 1.5.0
>
> Attachments: LiveTServerSet.java.patch
>
>
> A lock on the receiver is acquired twice by this method. This has two drawbacks (a) it slows performance and (b) is confusing.
> A patch is attached proposing the fix -- I left the method synchronized and removed the lock acquisition in the method to match the other methods in the class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ACCUMULO-855) Patch to remove acquisition of
redundant lock: LiveTServerSet in org.apache.accumulo.server.master
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497352#comment-13497352 ]
Hudson commented on ACCUMULO-855:
---------------------------------
Integrated in Accumulo-Trunk #552 (See [https://builds.apache.org/job/Accumulo-Trunk/552/])
ACCUMULO-855 applying patch to trunk (Revision 1409288)
Result = SUCCESS
ecn :
Files :
* /accumulo/trunk/server/src/main/java/org/apache/accumulo/server/master/LiveTServerSet.java
> Patch to remove acquisition of redundant lock: LiveTServerSet in org.apache.accumulo.server.master
> --------------------------------------------------------------------------------------------------
>
> Key: ACCUMULO-855
> URL: https://issues.apache.org/jira/browse/ACCUMULO-855
> Project: Accumulo
> Issue Type: Improvement
> Reporter: Tim Halloran
> Priority: Minor
> Fix For: 1.5.0
>
> Attachments: LiveTServerSet.java.patch
>
>
> A lock on the receiver is acquired twice by this method. This has two drawbacks (a) it slows performance and (b) is confusing.
> A patch is attached proposing the fix -- I left the method synchronized and removed the lock acquisition in the method to match the other methods in the class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ACCUMULO-855) Patch to remove acquisition of
redundant lock: LiveTServerSet in org.apache.accumulo.server.master
Posted by "Tim Halloran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ACCUMULO-855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Halloran updated ACCUMULO-855:
----------------------------------
Attachment: LiveTServerSet.java.patch
Proposed code patch.
> Patch to remove acquisition of redundant lock: LiveTServerSet in org.apache.accumulo.server.master
> --------------------------------------------------------------------------------------------------
>
> Key: ACCUMULO-855
> URL: https://issues.apache.org/jira/browse/ACCUMULO-855
> Project: Accumulo
> Issue Type: Improvement
> Reporter: Tim Halloran
> Priority: Minor
> Attachments: LiveTServerSet.java.patch
>
>
> A lock on the receiver is acquired twice by this method. This has two drawbacks (a) it slows performance and (b) is confusing.
> A patch is attached proposing the fix -- I left the method synchronized and removed the lock acquisition in the method to match the other methods in the class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira