You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/09/26 07:36:38 UTC

[GitHub] [tvm] LiangW526 opened a new pull request, #12901: [BugFix][Pattern] Fixed a bug in PatternGrouper

LiangW526 opened a new pull request, #12901:
URL: https://github.com/apache/tvm/pull/12901

   This commit adds a duplicate check for make_input in PatternGrouper::CreateGroup, fixes a bug where the partitioned function created by CreateGroup would have an unused redundant variable when multiple operators in the partition share an input.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi commented on pull request #12901: [BugFix][Pattern] Fixed a bug in PatternGrouper

Posted by GitBox <gi...@apache.org>.

masahi commented on PR #12901:
URL: https://github.com/apache/tvm/pull/12901#issuecomment-1259251522

   There is a legitimate error in `relay/test_pass_merge_composite.py`. Can you take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] LiangW526 commented on pull request #12901: [BugFix][Pattern] Fixed a bug in PatternGrouper

Posted by GitBox <gi...@apache.org>.

LiangW526 commented on PR #12901:
URL: https://github.com/apache/tvm/pull/12901#issuecomment-1262101037

   @masahi Thanks for reminding! I modified the `expected` function in test_pass_merge_composite.py::test_type_check, and made a minor change to cmsis-nn backend to fix the failure of test_binary_ops.py::test_same_input_to_binary_op
   Could you please take a look again? Thanks very much!
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org