[GitHub] [incubator-superset] nytai commented on a change in pull request #11278: fix: add schema name to datasource field in chart list

[GitBox <gi...@apache.org>]

nytai commented on a change in pull request #11278:
URL: https://github.com/apache/incubator-superset/pull/11278#discussion_r505832061



##########
File path: superset/models/slice.py
##########
@@ -140,9 +140,15 @@ def datasource_url(self) -> Optional[str]:
     def datasource_name_text(self) -> Optional[str]:
         # pylint: disable=no-member
         if self.table:
+            if self.table.schema:
+                return f"{self.table.schema}.{self.table.table_name}"
             return self.table.table_name
         datasource = self.datasource

Review comment:
       looks like most methods in this model share this inconsistency 😕 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org