You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/30 13:57:56 UTC

[GitHub] [pulsar] erobot opened a new pull request #8749: [Issue 8734][C++] Optimize batch message buffer allocation

erobot opened a new pull request #8749:
URL: https://github.com/apache/pulsar/pull/8749


   Fixes #8734
   
   ### Motivation
   
   Batch message should reserve some buffers for subsequent messages. See #8734 for performance impact case.
   
   ### Modifications
   
   Double buffer size everytime when not enough room. For new size, use maxMessageSizeInBytes for max hint and current buffer size + requiredSpace for min.
   
   ### Verifying this change
   
   Can fix performance impact case of #8734.
   
   ### Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] sijie merged pull request #8749: [Issue 8734][C++] Optimize batch message buffer allocation

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #8749:
URL: https://github.com/apache/pulsar/pull/8749


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org