You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "AntonRoskvist (via GitHub)" <gi...@apache.org> on 2025/03/20 14:39:48 UTC

[PR] Rollback of compressed messages return too many credits [activemq-artemis]

AntonRoskvist opened a new pull request, #5574:
URL: https://github.com/apache/activemq-artemis/pull/5574

   When messages are compressed and get small enough to pass as regular messages, consumer credits can get thrown off balance, in particular following a rollback.
   
   This has two effects:
   1. Consumers can get more messages "delivering" than what `consumerWindowSize` should allow.
   2. Over time, accumulated credits can overflow, causing negative credits and thereby marking the consumer as "busy".
   
   I am open to rewriting the test to be faster if you have any recommendations on it, I had some trouble formulating it in a good way that would demonstrate the issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact



Re: [PR] Rollback of compressed messages return too many credits [activemq-artemis]

Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic commented on PR #5574:
URL: https://github.com/apache/activemq-artemis/pull/5574#issuecomment-3175807612

   I replaced this PR at #5865 . Please review it there


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact



Re: [PR] Rollback of compressed messages return too many credits [activemq-artemis]

Posted by "AntonRoskvist (via GitHub)" <gi...@apache.org>.
AntonRoskvist commented on PR #5574:
URL: https://github.com/apache/activemq-artemis/pull/5574#issuecomment-3164362834

   Hi,
   
   I'd like some feedback on this PR if possible. @jbertram @clebertsuconic @tabish121 if any of you have the possibility I'd really appreciate it, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact



Re: [PR] Rollback of compressed messages return too many credits [activemq-artemis]

Posted by "clebertsuconic (via GitHub)" <gi...@apache.org>.
clebertsuconic closed pull request #5574: Rollback of compressed messages return too many credits
URL: https://github.com/apache/activemq-artemis/pull/5574


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact