You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Kirk Lund <ki...@gmail.com> on 2016/04/04 21:50:48 UTC
Review Request 45702: GEODE-103: fix usage of isProcessAlive to
remove race condition
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45702/
-----------------------------------------------------------
Review request for geode, Jens Deppe and Jinmei Liao.
Bugs: GEODE-103 and GEODE-1136
https://issues.apache.org/jira/browse/GEODE-103
https://issues.apache.org/jira/browse/GEODE-1136
Repository: geode
Description
-------
GEODE-103: fix usage of isProcessAlive to remove race condition
* update implementation of isProcessAlive to use JDK 1.8 API
* also fixes GEODE-1136
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/process/ProcessUtils.java c2841da
geode-core/src/test/java/com/gemstone/gemfire/internal/process/BlockingProcessStreamReaderJUnitTest.java d83d9fe
geode-core/src/test/java/com/gemstone/gemfire/internal/process/NonBlockingProcessStreamReaderJUnitTest.java ca8f1a5
Diff: https://reviews.apache.org/r/45702/diff/
Testing
-------
Thanks,
Kirk Lund
Re: Review Request 45702: GEODE-103: fix usage of isProcessAlive to
remove race condition
Posted by Jens Deppe <jd...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45702/#review126946
-----------------------------------------------------------
Ship it!
Ship It!
- Jens Deppe
On April 4, 2016, 7:50 p.m., Kirk Lund wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45702/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 7:50 p.m.)
>
>
> Review request for geode, Jens Deppe and Jinmei Liao.
>
>
> Bugs: GEODE-103 and GEODE-1136
> https://issues.apache.org/jira/browse/GEODE-103
> https://issues.apache.org/jira/browse/GEODE-1136
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-103: fix usage of isProcessAlive to remove race condition
>
> * update implementation of isProcessAlive to use JDK 1.8 API
> * also fixes GEODE-1136
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/process/ProcessUtils.java c2841da
> geode-core/src/test/java/com/gemstone/gemfire/internal/process/BlockingProcessStreamReaderJUnitTest.java d83d9fe
> geode-core/src/test/java/com/gemstone/gemfire/internal/process/NonBlockingProcessStreamReaderJUnitTest.java ca8f1a5
>
> Diff: https://reviews.apache.org/r/45702/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kirk Lund
>
>