You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "joke1196 (via GitHub)" <gi...@apache.org> on 2025/04/25 14:19:25 UTC
[PR] SPARK-51710 Passing an empty array to PySpark Dataframe.dropDuplicates should behave the same as passing no arguments [spark]
joke1196 opened a new pull request, #50714:
URL: https://github.com/apache/spark/pull/50714
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR aligns the behavior of `DataFrame.dropDuplicates([])` to be the same as `DataFrame.dropDuplicates()`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
When using PySpark `DataFrame.dropDuplicates` with an empty array as the `subset` argument, the resulting `DataFrame` contains a single row (the first row). This behavior is different than using `DataFrame.dropDuplicates` without any parameters or with None as the `subset` argument. I would expect that passing an empty array to `dropDuplicates` would use all the columns to detect duplicates and remove them.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
An assertion was added to `python/pyspark/sql/tests/test_dataframe.py`.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51710][PYTHON] Passing an empty array to PySpark Dataframe.dropDuplicates should behave the same as passing no arguments [spark]
Posted by "abhiips07 (via GitHub)" <gi...@apache.org>.
abhiips07 commented on PR #50714:
URL: https://github.com/apache/spark/pull/50714#issuecomment-2853282247
> Shall I then close this PR as well a the JIRA ticket?
imo this could be taken as an improvement, what do you think @HyukjinKwon ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51710][PYTHON] Passing an empty array to PySpark Dataframe.dropDuplicates should behave the same as passing no arguments [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #50714:
URL: https://github.com/apache/spark/pull/50714#issuecomment-2857439168
This seems to be a breaking change, can we start a discussion in the dev list to collect feedback?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51710][PYTHON] Passing an empty array to PySpark Dataframe.dropDuplicates should behave the same as passing no arguments [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50714:
URL: https://github.com/apache/spark/pull/50714#issuecomment-3193061857
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51710][PYTHON] Passing an empty array to PySpark Dataframe.dropDuplicates should behave the same as passing no arguments [spark]
Posted by "joke1196 (via GitHub)" <gi...@apache.org>.
joke1196 commented on PR #50714:
URL: https://github.com/apache/spark/pull/50714#issuecomment-2837729040
@HyukjinKwon Yes I should have started with that. The behavior is the same, meaning `dropDuplicates(Seq.empty)` outputs only one row. I guess this makes this PR irrelevant, but still, I find the behavior counter intuitive, is this really the intended behavior? If it is not the case I would love to try and fix it on the Scala side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] SPARK-51710 Passing an empty array to PySpark Dataframe.dropDuplicates should behave the same as passing no arguments [spark]
Posted by "abhiips07 (via GitHub)" <gi...@apache.org>.
abhiips07 commented on code in PR #50714:
URL: https://github.com/apache/spark/pull/50714#discussion_r2063178112
##########
python/pyspark/sql/classic/dataframe.py:
##########
@@ -1190,7 +1190,7 @@ def dropDuplicatesWithinWatermark(self, subset: Optional[List[str]] = None) -> P
messageParameters={"arg_name": "subset", "arg_type": type(subset).__name__},
)
- if subset is None:
+ if not subset:
Review Comment:
@HyukjinKwon any thoughts on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51710][PYTHON] Passing an empty array to PySpark Dataframe.dropDuplicates should behave the same as passing no arguments [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #50714:
URL: https://github.com/apache/spark/pull/50714#issuecomment-2840434633
yeah, I am trying to figure out if this is 1. consistent with the existing behaviour or 2. complies any standard. Could we check if ANSI SQL standard?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51710][PYTHON] Passing an empty array to PySpark Dataframe.dropDuplicates should behave the same as passing no arguments [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #50714:
URL: https://github.com/apache/spark/pull/50714#issuecomment-2856398491
I would just like to make sure that we can justify this behaviour. cc @gengliangwang @cloud-fan too FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51710][PYTHON] Passing an empty array to PySpark Dataframe.dropDuplicates should behave the same as passing no arguments [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #50714: [SPARK-51710][PYTHON] Passing an empty array to PySpark Dataframe.dropDuplicates should behave the same as passing no arguments
URL: https://github.com/apache/spark/pull/50714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51710][PYTHON] Passing an empty array to PySpark Dataframe.dropDuplicates should behave the same as passing no arguments [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #50714:
URL: https://github.com/apache/spark/pull/50714#discussion_r2065009631
##########
python/pyspark/sql/classic/dataframe.py:
##########
@@ -1190,7 +1190,7 @@ def dropDuplicatesWithinWatermark(self, subset: Optional[List[str]] = None) -> P
messageParameters={"arg_name": "subset", "arg_type": type(subset).__name__},
)
- if subset is None:
+ if not subset:
Review Comment:
yeah I prefer to be explicit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51710][PYTHON] Passing an empty array to PySpark Dataframe.dropDuplicates should behave the same as passing no arguments [spark]
Posted by "joke1196 (via GitHub)" <gi...@apache.org>.
joke1196 commented on PR #50714:
URL: https://github.com/apache/spark/pull/50714#issuecomment-2851045906
Shall I then close this PR as well a the JIRA ticket?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] SPARK-51710 Passing an empty array to PySpark Dataframe.dropDuplicates should behave the same as passing no arguments [spark]
Posted by "joke1196 (via GitHub)" <gi...@apache.org>.
joke1196 commented on code in PR #50714:
URL: https://github.com/apache/spark/pull/50714#discussion_r2063076830
##########
python/pyspark/sql/classic/dataframe.py:
##########
@@ -1190,7 +1190,7 @@ def dropDuplicatesWithinWatermark(self, subset: Optional[List[str]] = None) -> P
messageParameters={"arg_name": "subset", "arg_type": type(subset).__name__},
)
- if subset is None:
+ if not subset:
Review Comment:
@abhiips07 Thanks for the review! Sure, I will make it explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51710][PYTHON] Passing an empty array to PySpark Dataframe.dropDuplicates should behave the same as passing no arguments [spark]
Posted by "abhiips07 (via GitHub)" <gi...@apache.org>.
abhiips07 commented on PR #50714:
URL: https://github.com/apache/spark/pull/50714#issuecomment-2837834689
> @HyukjinKwon Yes I should have started with that. The behavior is the same, meaning `dropDuplicates(Seq.empty)` outputs only one row. I guess this makes this PR irrelevant, but still, I find the behavior counter intuitive, is this really the intended behavior? If it is not the case I would love to try and fix it on the Scala side.
I guess this is expected behaviour though a bit counter intuitive, In case of `dropDuplicates(Seq.empty)`, it is treating all rows to be duplicate of each other hence retaining only 1st row. But as an improvement we can fix this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] SPARK-51710 Passing an empty array to PySpark Dataframe.dropDuplicates should behave the same as passing no arguments [spark]
Posted by "abhiips07 (via GitHub)" <gi...@apache.org>.
abhiips07 commented on code in PR #50714:
URL: https://github.com/apache/spark/pull/50714#discussion_r2061272430
##########
python/pyspark/sql/classic/dataframe.py:
##########
@@ -1190,7 +1190,7 @@ def dropDuplicatesWithinWatermark(self, subset: Optional[List[str]] = None) -> P
messageParameters={"arg_name": "subset", "arg_type": type(subset).__name__},
)
- if subset is None:
+ if not subset:
Review Comment:
imo using `if subset is None or len(subset) == 0:` would be wiser to use, specifically checking for None or an empty list, ensuring we only deduplicate across all columns in those cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51710][PYTHON] Passing an empty array to PySpark Dataframe.dropDuplicates should behave the same as passing no arguments [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #50714:
URL: https://github.com/apache/spark/pull/50714#issuecomment-2837005752
Can we check if this behaivour is consistent with Scala? E.g., `df.dropDuplicates(Seq.empty)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51710][PYTHON] Passing an empty array to PySpark Dataframe.dropDuplicates should behave the same as passing no arguments [spark]
Posted by "abhiips07 (via GitHub)" <gi...@apache.org>.
abhiips07 commented on PR #50714:
URL: https://github.com/apache/spark/pull/50714#issuecomment-2840742273
> yeah, I am trying to figure out if this is 1. consistent with the existing behaviour or 2. complies any standard. Could we check if ANSI SQL standard?
yes, this is similar to `GROUP BY ()` in ANSI SQL, where everything is grouped into one group, This is not a direct SQL equivalent, but conceptually similar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51710][PYTHON] Passing an empty array to PySpark Dataframe.dropDuplicates should behave the same as passing no arguments [spark]
Posted by "abhiips07 (via GitHub)" <gi...@apache.org>.
abhiips07 commented on PR #50714:
URL: https://github.com/apache/spark/pull/50714#issuecomment-2857477035
@joke1196 Pls do the needful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org