You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by caofangkun <gi...@git.apache.org> on 2014/12/22 09:33:04 UTC
[GitHub] storm pull request: STORM-598:Newly submitted topologies do not sh...
GitHub user caofangkun opened a pull request:
https://github.com/apache/storm/pull/355
STORM-598:Newly submitted topologies do not show up on the storm ui cluser page when the Storm Cluster run out of worker slots
1: Set up a Storm Cluster with 1 Supervisor(4 worker slots)
2: submit topologyA and use 4 workers
3: submit topologyB with 4 workers
topologyB does not but should show up on the storm ui cluster page.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/caofangkun/apache-storm storm-598
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/355.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #355
----
commit 97ae36e42abc961fbcc54dd77c80bafff30dce7e
Author: caofangkun <ca...@gmail.com>
Date: 2014-12-22T08:18:08Z
Merge pull request #2 from apache/master
Merge from trunk to caofangkun
commit b2b7f7e0b079f01344f0efcf6a6b17365ff21cc7
Author: caofangkun <ca...@gmail.com>
Date: 2014-12-22T08:29:43Z
STORM-598:Newly submitted topologies do not show up on the storm ui cluser page when the Storm Cluster run out of worker slots
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-598:Newly submitted topologies do not sh...
Posted by caofangkun <gi...@git.apache.org>.
Github user caofangkun closed the pull request at:
https://github.com/apache/storm/pull/355
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-598:Newly submitted topologies do not sh...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/355#issuecomment-71263582
The code compiles now, but I still have not been able to reproduce the original cause of this problem. am I doing something wrong?
```
./bin/storm dev-zookeeper &
./bin/storm nimbus &
./bin/storm supervisor &
./bin/storm ui &
./bin/storm logviewer &
```
wait for the UI to come up
```
./bin/storm jar ./examples/storm-starter/storm-starter-topologies-0.10.0-SNAPSHOT.jar storm.starter.WordCountTopology wc -c topology.workers=4
./bin/storm jar ./examples/storm-starter/storm-starter-topologies-0.10.0-SNAPSHOT.jar storm.starter.WordCountTopology wc-2 -c topology.workers=4
```
Both show up in the TopologySummary section of the index.html page.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-598:Newly submitted topologies do not sh...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/355#discussion_r22236169
--- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj ---
@@ -1248,7 +1256,7 @@
(when-let [owner (:owner base)] (.set_owner topo-summ owner))
(when-let [sched-status (.get @(:id->sched-status nimbus) id)] (.set_sched_status topo-summ sched-status))
topo-summ
- ))]
+ )))]
--- End diff --
The new ')' is in the wrong place. It should be up on line 1255 instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-598:Newly submitted topologies do not sh...
Posted by caofangkun <gi...@git.apache.org>.
Github user caofangkun commented on the pull request:
https://github.com/apache/storm/pull/355#issuecomment-71407839
@revans2
I have tried on master. The UI indeed display correctly. This should be no longer a issue.
Thanks for your attention and patience.
I will close this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-598:Newly submitted topologies do not sh...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/355#issuecomment-68001550
Also I tried to reproduce the issue on master and I am seeing the second topology come up on the ui without any issues. Could you try to reproduce the error on master and let me know if it is still an issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---