[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3237: [KYUUBI #3171] Expose mysql frontend connection metrics

[GitBox <gi...@apache.org>]

pan3793 commented on code in PR #3237:
URL: https://github.com/apache/incubator-kyuubi/pull/3237#discussion_r947084596


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/mysql/MySQLCommandHandler.scala:
##########
@@ -53,6 +55,8 @@ class MySQLCommandHandler(be: BackendService, execPool: ThreadPoolExecutor)
 
   // handle process exception, generally should send error packet
   override def exceptionCaught(ctx: ChannelHandlerContext, cause: Throwable): Unit = {
+    MetricsSystem.tracing(_.incCount(MYSQL_CONN_FAIL))

Review Comment:
   I don't think so, if the socket is broken, then `channel.isActive` should be false



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org