You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Yulei-Yang (via GitHub)" <gi...@apache.org> on 2024/09/23 04:11:59 UTC
[PR] [temp_table] add docs for temp table [doris-website]
Yulei-Yang opened a new pull request, #1135:
URL: https://github.com/apache/doris-website/pull/1135
# Versions
- [x] dev
- [x] 3.0
- [x] 2.1
- [ ] 2.0
# Languages
- [x] Chinese
- [x] English
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [temp_table] add docs for temp table [doris-website]
Posted by "KassieZ (via GitHub)" <gi...@apache.org>.
KassieZ commented on code in PR #1135:
URL: https://github.com/apache/doris-website/pull/1135#discussion_r1773010940
##########
i18n/zh-CN/docusaurus-plugin-content-docs/current/table-design/temporary-table.md:
##########
Review Comment:
Thank you for contribution
1.please use Chinese in docs and use :::info 备注 ::: instead of :::note :::
<img width="314" alt="image" src="https://github.com/user-attachments/assets/9315c46f-0445-44b9-96fe-5ce667d0e047">
2.please fix the typo
<img width="762" alt="image" src="https://github.com/user-attachments/assets/e73eb764-4a7e-4031-a58d-171c3e5f7d24">
3.please make sure the capitalization is unified, such as SQL (All caps) , Session(Sentence case) , Rollup (Sentence case)
4.please add blank between Chinese and EN words or Numbers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [temporary_table] add docs for temporary table [doris-website]
Posted by "Yulei-Yang (via GitHub)" <gi...@apache.org>.
Yulei-Yang commented on PR #1135:
URL: https://github.com/apache/doris-website/pull/1135#issuecomment-2727845179
> Please resolve the conflict and also update docs on Version 2.1/3.0
this feature will only applied to 3.0, no 2.1. Docs for v3.0 updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [temporary_table] add docs for temporary table [doris-website]
Posted by "Yulei-Yang (via GitHub)" <gi...@apache.org>.
Yulei-Yang commented on code in PR #1135:
URL: https://github.com/apache/doris-website/pull/1135#discussion_r1997636961
##########
i18n/zh-CN/docusaurus-plugin-content-docs/current/table-design/temporary-table.md:
##########
@@ -0,0 +1,60 @@
+---
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [temporary_table] add docs for temporary table [doris-website]
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #1135:
URL: https://github.com/apache/doris-website/pull/1135#issuecomment-2407362082
we can not put new feature into 2.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [temporary_table] add docs for temporary table [doris-website]
Posted by "KassieZ (via GitHub)" <gi...@apache.org>.
KassieZ commented on PR #1135:
URL: https://github.com/apache/doris-website/pull/1135#issuecomment-2527481083
Please resolve the conflict and also update docs on Version 2.1/3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [temporary_table] add docs for temporary table [doris-website]
Posted by "Yulei-Yang (via GitHub)" <gi...@apache.org>.
Yulei-Yang closed pull request #1135: [temporary_table] add docs for temporary table
URL: https://github.com/apache/doris-website/pull/1135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [temporary_table] add docs for temporary table [doris-website]
Posted by "Yulei-Yang (via GitHub)" <gi...@apache.org>.
Yulei-Yang commented on code in PR #1135:
URL: https://github.com/apache/doris-website/pull/1135#discussion_r1997632870
##########
docs/table-design/temporary-table.md:
##########
@@ -0,0 +1,61 @@
+---
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [temporary_table] add docs for temporary table [doris-website]
Posted by "KassieZ (via GitHub)" <gi...@apache.org>.
KassieZ commented on code in PR #1135:
URL: https://github.com/apache/doris-website/pull/1135#discussion_r1875706419
##########
docs/table-design/temporary-table.md:
##########
@@ -0,0 +1,61 @@
+---
Review Comment:
Please follow the format:
```text
---
{
"title": "",
"language": ""
}
---
```
##########
i18n/zh-CN/docusaurus-plugin-content-docs/current/table-design/temporary-table.md:
##########
@@ -0,0 +1,60 @@
+---
Review Comment:
Please follow the format:
```text
---
{
"title": "",
"language": ""
}
---
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [temporary_table] add docs for temporary table [doris-website]
Posted by "Yulei-Yang (via GitHub)" <gi...@apache.org>.
Yulei-Yang commented on PR #1135:
URL: https://github.com/apache/doris-website/pull/1135#issuecomment-2428185635
> we can not put new feature into 2.1
get
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org