[jira] [Commented] (NUTCH-2442) Injector to stop if job fails to avoid loss of CrawlDb

["Omkar Reddy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NUTCH-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238278#comment-16238278 ] 

Omkar Reddy commented on NUTCH-2442:
------------------------------------

[~wastl-nagel] I am working on this on my local branch of NUTCH-2375. Just so that I do not head in the wrong direction, I was thinking the fix should be in the following manner :

try{
  boolean complete = job.waitForCompletion(true);
  if(!complete){
    ''' cleanup statements to revert any significant changes that happened during or before the job.'''
    throw new Exception("<specific job> FAILED.");
  }
}catch(Exception e){
  throw e;
}

Please let me know if I need to add anything else or if there is any discrepancy in what I am doing above. Thanks. 


> Injector to stop if job fails to avoid loss of CrawlDb
> ------------------------------------------------------
>
>                 Key: NUTCH-2442
>                 URL: https://issues.apache.org/jira/browse/NUTCH-2442
>             Project: Nutch
>          Issue Type: Bug
>          Components: injector
>    Affects Versions: 1.13
>            Reporter: Sebastian Nagel
>            Priority: Critical
>             Fix For: 1.14
>
>
> Injector does not check whether the MapReduce job is successful. Even if the job fails
> - installs the CrawlDb
> -- move current/ to old/
> -- replace current/ with an empty or potentially incomplete version
> - exits with code 0 so that scripts running the crawl workflow cannot detect the failure -- if Injector is run a second time the CrawlDb is lost (both current/ and old/ are empty or corrupted)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)