You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2019/06/30 21:55:50 UTC

[commons-numbers] 03/09: NUMBERS-119: Simplify assignment of local variable

This is an automated email from the ASF dual-hosted git repository.

erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-numbers.git

commit e96c11880a95376de925829fae9f7153940e8bd3
Author: Schamschi <he...@gmx.at>
AuthorDate: Sun Jun 23 13:02:09 2019 +0200

    NUMBERS-119: Simplify assignment of local variable
    
    The variable exponent is explicitly known to be zero at this point, because the conditional branch depends on this property, so no need to refer to the variable
---
 .../src/main/java/org/apache/commons/numbers/fraction/BigFraction.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java b/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java
index 2108eb8..109a0cc 100644
--- a/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java
+++ b/commons-numbers-fraction/src/main/java/org/apache/commons/numbers/fraction/BigFraction.java
@@ -238,7 +238,7 @@ public class BigFraction extends Number implements Comparable<BigFraction>, Seri
                 k = 0;
             } else {
                 // subnormal number, the effective exponent bias is only 1022
-                k = ((int) (exponent >> 52)) - 1022 - 52;
+                k = - 1022 - 52;
             }
         }
         if (sign != 0) {