You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/05/04 18:59:58 UTC

[GitHub] [airflow] Acehaidrey commented on a change in pull request #8681: Prevent clickable sorting on non sortable columns in TI view

Acehaidrey commented on a change in pull request #8681:
URL: https://github.com/apache/airflow/pull/8681#discussion_r419658098



##########
File path: airflow/www/views.py
##########
@@ -2627,6 +2627,9 @@ class TaskInstanceModelView(AirflowModelView):
                     'unixname', 'priority_weight', 'queue', 'queued_dttm', 'try_number',
                     'pool', 'log_url']
 
+    # this is to remove the sorting option on these columns that raise `property has no attribute asc`
+    order_columns = [item for item in list_columns.copy() if item not in ['try_number', 'log_url']]

Review comment:
       I agree with you. Have removed the comment. And also removing the .copy(). Thanks for your help on this




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org