You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by GitBox <gi...@apache.org> on 2022/09/02 09:56:04 UTC
[GitHub] [cassandra] maoling opened a new pull request, #1839: CASSANDRA-17876: remove the unused imports in the source code
maoling opened a new pull request, #1839:
URL: https://github.com/apache/cassandra/pull/1839
- remove the unused imports in the source code to make the codebase more neat
- Ant build has been SUCCESSFUL
- more details in [CASSANDRA-17876](https://issues.apache.org/jira/browse/CASSANDRA-17876)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #1839: CASSANDRA-17876: remove the unused imports in the source code
Posted by GitBox <gi...@apache.org>.
smiklosovic commented on code in PR #1839:
URL: https://github.com/apache/cassandra/pull/1839#discussion_r961767524
##########
checkstyle.xml:
##########
@@ -95,6 +95,8 @@
<property name="illegalPkgs" value="junit.framework"/>
<property name="illegalClasses" value="java.io.File,java.io.FileInputStream,java.io.FileOutputStream,java.io.FileReader,java.io.FileWriter,java.io.RandomAccessFile,java.util.concurrent.Semaphore,java.util.concurrent.CountDownLatch,java.util.concurrent.Executors,java.util.concurrent.LinkedBlockingQueue,java.util.concurrent.SynchronousQueue,java.util.concurrent.ArrayBlockingQueue,com.google.common.util.concurrent.Futures,java.util.concurrent.CompletableFuture,io.netty.util.concurrent.Future,io.netty.util.concurrent.Promise,io.netty.util.concurrent.AbstractFuture,com.google.common.util.concurrent.ListenableFutureTask,com.google.common.util.concurrent.ListenableFuture,com.google.common.util.concurrent.AbstractFuture"/>
</module>
+ <module name="RedundantImport"/>
Review Comment:
@maoling why did you put these modules exactly just here? What's wrong with putting them at the end?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic commented on a diff in pull request #1839: CASSANDRA-17876: remove the unused imports in the source code
Posted by GitBox <gi...@apache.org>.
smiklosovic commented on code in PR #1839:
URL: https://github.com/apache/cassandra/pull/1839#discussion_r962874774
##########
checkstyle.xml:
##########
@@ -95,6 +95,8 @@
<property name="illegalPkgs" value="junit.framework"/>
<property name="illegalClasses" value="java.io.File,java.io.FileInputStream,java.io.FileOutputStream,java.io.FileReader,java.io.FileWriter,java.io.RandomAccessFile,java.util.concurrent.Semaphore,java.util.concurrent.CountDownLatch,java.util.concurrent.Executors,java.util.concurrent.LinkedBlockingQueue,java.util.concurrent.SynchronousQueue,java.util.concurrent.ArrayBlockingQueue,com.google.common.util.concurrent.Futures,java.util.concurrent.CompletableFuture,io.netty.util.concurrent.Future,io.netty.util.concurrent.Promise,io.netty.util.concurrent.AbstractFuture,com.google.common.util.concurrent.ListenableFutureTask,com.google.common.util.concurrent.ListenableFuture,com.google.common.util.concurrent.AbstractFuture"/>
</module>
+ <module name="RedundantImport"/>
Review Comment:
ok to the first bullet point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] maoling commented on a diff in pull request #1839: CASSANDRA-17876: remove the unused imports in the source code
Posted by GitBox <gi...@apache.org>.
maoling commented on code in PR #1839:
URL: https://github.com/apache/cassandra/pull/1839#discussion_r962764017
##########
checkstyle.xml:
##########
@@ -95,6 +95,8 @@
<property name="illegalPkgs" value="junit.framework"/>
<property name="illegalClasses" value="java.io.File,java.io.FileInputStream,java.io.FileOutputStream,java.io.FileReader,java.io.FileWriter,java.io.RandomAccessFile,java.util.concurrent.Semaphore,java.util.concurrent.CountDownLatch,java.util.concurrent.Executors,java.util.concurrent.LinkedBlockingQueue,java.util.concurrent.SynchronousQueue,java.util.concurrent.ArrayBlockingQueue,com.google.common.util.concurrent.Futures,java.util.concurrent.CompletableFuture,io.netty.util.concurrent.Future,io.netty.util.concurrent.Promise,io.netty.util.concurrent.AbstractFuture,com.google.common.util.concurrent.ListenableFutureTask,com.google.common.util.concurrent.ListenableFuture,com.google.common.util.concurrent.AbstractFuture"/>
</module>
+ <module name="RedundantImport"/>
Review Comment:
- Because I want to put all the modules about import together with `IllegalImport`, Now I have put the new added modules at the end of `checkstyle.xml`
- I take a look at the discussions under the [JIRA](https://issues.apache.org/jira/browse/CASSANDRA-17876), if any other review comments I will process asap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra] smiklosovic closed pull request #1839: CASSANDRA-17876: remove the unused imports in the source code
Posted by GitBox <gi...@apache.org>.
smiklosovic closed pull request #1839: CASSANDRA-17876: remove the unused imports in the source code
URL: https://github.com/apache/cassandra/pull/1839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org