You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/09/11 06:33:03 UTC
[GitHub] [couchdb] nickva opened a new pull request #3746: Remove couch_icu_driver module
nickva opened a new pull request #3746:
URL: https://github.com/apache/couchdb/pull/3746
couch_icu_driver is only used for binary strings comparison in couch_ejson_compare when expression depth becomes greater than 10.
The logic for the comparison is identical to what couch_ejson_compare uses, so opt to just use couch_ejson_compare only, instead of keeping a whole other binary collation driver around.
To avoid a possible infinite loop if couch_ejson_compare NIF fails to load, throw a nif loading error as is common for NIF modules.
To avoid another case of a possible infinite retry from of badarg generated from by max depth, and an actual bad ejson term, use a specific max depth error so we don't have to guess when we catch it and retry term traversal in erlang.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on pull request #3746: Remove couch_icu_driver module
Posted by GitBox <gi...@apache.org>.
nickva commented on pull request #3746:
URL: https://github.com/apache/couchdb/pull/3746#issuecomment-917415831
@wohali yeah definitely, let's wait
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva edited a comment on pull request #3746: Remove couch_icu_driver module
Posted by GitBox <gi...@apache.org>.
nickva edited a comment on pull request #3746:
URL: https://github.com/apache/couchdb/pull/3746#issuecomment-939114457
3.2 has been tagged, I think we can take another look at the PR.
Hopefully the property tests would give us some more confidence about it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on pull request #3746: Remove couch_icu_driver module
Posted by GitBox <gi...@apache.org>.
nickva commented on pull request #3746:
URL: https://github.com/apache/couchdb/pull/3746#issuecomment-939114457
3.2 has been tagged, I think we can take another look at the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva merged pull request #3746: Remove couch_icu_driver module
Posted by GitBox <gi...@apache.org>.
nickva merged pull request #3746:
URL: https://github.com/apache/couchdb/pull/3746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] wohali commented on pull request #3746: Remove couch_icu_driver module
Posted by GitBox <gi...@apache.org>.
wohali commented on pull request #3746:
URL: https://github.com/apache/couchdb/pull/3746#issuecomment-917361272
I would hold this until after 3.2 - seems like too subtle of a change to push in at the last minute, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva removed a comment on pull request #3746: Remove couch_icu_driver module
Posted by GitBox <gi...@apache.org>.
nickva removed a comment on pull request #3746:
URL: https://github.com/apache/couchdb/pull/3746#issuecomment-918254202
We can probably borrow the ejson PropEr generator from jiffy tests and run property tests asserting that erlang's collation is equivalent to one in the NIF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on pull request #3746: Remove couch_icu_driver module
Posted by GitBox <gi...@apache.org>.
nickva commented on pull request #3746:
URL: https://github.com/apache/couchdb/pull/3746#issuecomment-918254202
We can probably borrow the ejson PropEr generator from jiffy tests and run property tests asserting that erlang's collation is equivalent to one in the NIF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on pull request #3746: Remove couch_icu_driver module
Posted by GitBox <gi...@apache.org>.
nickva commented on pull request #3746:
URL: https://github.com/apache/couchdb/pull/3746#issuecomment-944303596
Added the `compare_strings` function. The code looks better without the confusing recursive `less_erl` back to `less_nif` jump.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org