[GitHub] [phoenix] gjacoby126 commented on a change in pull request #648: Phoenix 5591 Fail indextool if split-merge happens during job run

[GitBox <gi...@apache.org>]

gjacoby126 commented on a change in pull request #648: Phoenix 5591 Fail indextool if split-merge happens during job run
URL: https://github.com/apache/phoenix/pull/648#discussion_r354049386
 
 

 ##########
 File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexToolIT.java
 ##########
 @@ -633,6 +635,83 @@ public void testSplitIndex() throws Exception {
         }
     }
 
+    /**
+     * Test that index tool fails when data table splits
+     */
+    @Test
+    public void testDataTableSplit() throws Exception {
 
 Review comment:
   This test verifies that the "end region count" is calculated to be non-zero and fails the index tool when the index tool expects 0 regions. Seems like we'd also need a test that verifies that the initial count is populated into the M/R config properly. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services