You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shardingsphere.apache.org by 吴伟杰 <wu...@apache.org> on 2021/06/30 15:19:40 UTC
[DISCUSS] Remove ShardingSphere SkyWalking agent plugins for legacy
version from SkyWalking's master branch
Hi All,
SkyWalking's master branch hosts 7 agent plugins for different versions of
ShardingSphere.
They think the plugins are too many. (
https://github.com/apache/skywalking/pull/7171#issuecomment-868353013)
Here is the list:
1.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-jdbc-1.5.x-plugin
2.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-3.x-plugin
3.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.0.x-plugin
4.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.1.0-plugin
5.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-RC3-plugin
6.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-plugin
7.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/shardingsphere-5.0.0-beta-plugin
Since the sharding-jdbc-1.5.x and the sharding-sphere-3.x have no longer
been maintained, I propose to
remove sharding-jdbc-1.5.x-plugin
<https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-jdbc-1.5.x-plugin>
and sharding-sphere-3.x-plugin
<https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-3.x-plugin>
from
SkyWalking's master branch to reduce maintenance costs.
------------------
Sincerely,
Weijie Wu (TeslaCN)
Apache ShardingSphere
Re: [DISCUSS] Remove ShardingSphere SkyWalking agent plugins for
legacy version from SkyWalking's master branch
Posted by Sheng Wu <wu...@gmail.com>.
Thank you so much to polish this.
I have approved it.
Sheng Wu 吴晟
Twitter, wusheng1108
吴伟杰 <wu...@apache.org> 于2021年7月18日周日 下午6:34写道：
> Hi Sheng
>
> I have submitted a PR to do that.
> https://github.com/apache/skywalking/pull/7323
>
> ------------------
>
> Sincerely,
> Weijie Wu (TeslaCN)
> Apache ShardingSphere
>
> Sheng Wu <wu...@gmail.com> 于2021年7月14日周三 下午5:42写道：
> >
> > Hi Weijie
> >
> > Could you submit a pull request to remove all these?
> >
> > Sheng Wu 吴晟
> > Twitter, wusheng1108
> >
> >
> > Juan Pan <pa...@apache.org> 于2021年7月12日周一 下午12:19写道：
> >
> > > +1 from me.
> > >
> > >
> > >
> > >
> > >
> ------------------------------------------------------------------------------
> > > Juan Pan(Trista), Apache ShardingSphere PMC
> > > Twitter, @trista86934690
> > >
> > >
> > > On 07/11/2021 19:05，吴伟杰<wu...@apache.org> wrote：
> > > Hi
> > >
> > > Consider the 3.x is a GA release, and the plugins for 4.x RC are no
> > > longer needed because there are already plugins for 4.x GA.
> > > Our primary conclusion is removing the following plugins:
> > > 1. sharding-jdbc-1.5.x-plugin
> > > 2. sharding-sphere-4.x-rc3-plugin
> > > 3. sharding-sphere-4.x-plugin (This is for RC1 and RC2)
> > >
> > > If no one objects, I will clear up the codebase next weekend.
> > >
> > > ------------------
> > >
> > > Sincerely,
> > > Weijie Wu (TeslaCN)
> > > Apache ShardingSphere
> > >
> > > Sheng Wu <wu...@gmail.com> 于2021年7月11日周日 上午9:12写道：
> > >
> > > Hi
> > >
> > > Do we have a conclusion? And Weijie, could you follow this and clear
> up the
> > > codebase?
> > >
> > > Sheng Wu 吴晟
> > > Twitter, wusheng1108
> > >
> > >
> > > Juan Pan <pa...@apache.org> 于2021年7月1日周四 上午9:11写道：
> > >
> > > Hi,
> > >
> > >
> > > I have no clear idea on how each plugin is different, but they are
> > > actually different.
> > > Considering users' preference for different releases,My +1 to keep the
> 4.0
> > > and 4.1 GA versions.
> > >
> > >
> > >
> > >
> > >
> > >
> ------------------------------------------------------------------------------
> > > Juan Pan(Trista), Apache ShardingSphere PMC, Apache brpc (Incubating)
> IPMC
> > > Twitter, @trista86934690
> > >
> > >
> > > On 07/1/2021 07:50，Sheng Wu<wu...@gmail.com> wrote：
> > > Hi
> > >
> > > ```
> > > 3.
> > >
> > >
> > >
> > >
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.0.x-plugin
> > > 4.
> > >
> > >
> > >
> > >
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.1.0-plugin
> > > 5.
> > >
> > >
> > >
> > >
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-RC3-plugin
> > > 6.
> > >
> > >
> > >
> > >
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-plugin
> > > ```
> > >
> > > What is the difference between 4.x and 4.0/4.1 plugins? Could some of
> them
> > > be removed?
> > > And RC3 should be removed as you have plugins for GA releases already.
> > >
> > > Sheng Wu 吴晟
> > > Twitter, wusheng1108
> > >
> > >
> > > 吴伟杰 <wu...@apache.org> 于2021年6月30日周三 下午11:19写道：
> > >
> > > Hi All,
> > >
> > > SkyWalking's master branch hosts 7 agent plugins for different
> versions of
> > > ShardingSphere.
> > > They think the plugins are too many. (
> > > https://github.com/apache/skywalking/pull/7171#issuecomment-868353013)
> > > Here is the list:
> > >
> > > 1.
> > >
> > >
> > >
> > >
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-jdbc-1.5.x-plugin
> > > 2.
> > >
> > >
> > >
> > >
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-3.x-plugin
> > > 3.
> > >
> > >
> > >
> > >
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.0.x-plugin
> > > 4.
> > >
> > >
> > >
> > >
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.1.0-plugin
> > > 5.
> > >
> > >
> > >
> > >
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-RC3-plugin
> > > 6.
> > >
> > >
> > >
> > >
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-plugin
> > > 7.
> > >
> > >
> > >
> > >
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/shardingsphere-5.0.0-beta-plugin
> > >
> > >
> > > Since the sharding-jdbc-1.5.x and the sharding-sphere-3.x have no
> longer
> > > been maintained, I propose to
> > > remove sharding-jdbc-1.5.x-plugin
> > > <
> > >
> > >
> > >
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-jdbc-1.5.x-plugin
> > >
> > > and sharding-sphere-3.x-plugin
> > > <
> > >
> > >
> > >
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-3.x-plugin
> > >
> > > from
> > > SkyWalking's master branch to reduce maintenance costs.
> > >
> > > ------------------
> > >
> > > Sincerely,
> > > Weijie Wu (TeslaCN)
> > > Apache ShardingSphere
> > >
> > >
> > >
>
Re: [DISCUSS] Remove ShardingSphere SkyWalking agent plugins for
legacy version from SkyWalking's master branch
Posted by 吴伟杰 <wu...@apache.org>.
Hi Sheng
I have submitted a PR to do that.
https://github.com/apache/skywalking/pull/7323
------------------
Sincerely,
Weijie Wu (TeslaCN)
Apache ShardingSphere
Sheng Wu <wu...@gmail.com> 于2021年7月14日周三 下午5:42写道：
>
> Hi Weijie
>
> Could you submit a pull request to remove all these?
>
> Sheng Wu 吴晟
> Twitter, wusheng1108
>
>
> Juan Pan <pa...@apache.org> 于2021年7月12日周一 下午12:19写道：
>
> > +1 from me.
> >
> >
> >
> >
> > ------------------------------------------------------------------------------
> > Juan Pan(Trista), Apache ShardingSphere PMC
> > Twitter, @trista86934690
> >
> >
> > On 07/11/2021 19:05，吴伟杰<wu...@apache.org> wrote：
> > Hi
> >
> > Consider the 3.x is a GA release, and the plugins for 4.x RC are no
> > longer needed because there are already plugins for 4.x GA.
> > Our primary conclusion is removing the following plugins:
> > 1. sharding-jdbc-1.5.x-plugin
> > 2. sharding-sphere-4.x-rc3-plugin
> > 3. sharding-sphere-4.x-plugin (This is for RC1 and RC2)
> >
> > If no one objects, I will clear up the codebase next weekend.
> >
> > ------------------
> >
> > Sincerely,
> > Weijie Wu (TeslaCN)
> > Apache ShardingSphere
> >
> > Sheng Wu <wu...@gmail.com> 于2021年7月11日周日 上午9:12写道：
> >
> > Hi
> >
> > Do we have a conclusion? And Weijie, could you follow this and clear up the
> > codebase?
> >
> > Sheng Wu 吴晟
> > Twitter, wusheng1108
> >
> >
> > Juan Pan <pa...@apache.org> 于2021年7月1日周四 上午9:11写道：
> >
> > Hi,
> >
> >
> > I have no clear idea on how each plugin is different, but they are
> > actually different.
> > Considering users' preference for different releases,My +1 to keep the 4.0
> > and 4.1 GA versions.
> >
> >
> >
> >
> >
> > ------------------------------------------------------------------------------
> > Juan Pan(Trista), Apache ShardingSphere PMC, Apache brpc (Incubating) IPMC
> > Twitter, @trista86934690
> >
> >
> > On 07/1/2021 07:50，Sheng Wu<wu...@gmail.com> wrote：
> > Hi
> >
> > ```
> > 3.
> >
> >
> >
> > https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.0.x-plugin
> > 4.
> >
> >
> >
> > https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.1.0-plugin
> > 5.
> >
> >
> >
> > https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-RC3-plugin
> > 6.
> >
> >
> >
> > https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-plugin
> > ```
> >
> > What is the difference between 4.x and 4.0/4.1 plugins? Could some of them
> > be removed?
> > And RC3 should be removed as you have plugins for GA releases already.
> >
> > Sheng Wu 吴晟
> > Twitter, wusheng1108
> >
> >
> > 吴伟杰 <wu...@apache.org> 于2021年6月30日周三 下午11:19写道：
> >
> > Hi All,
> >
> > SkyWalking's master branch hosts 7 agent plugins for different versions of
> > ShardingSphere.
> > They think the plugins are too many. (
> > https://github.com/apache/skywalking/pull/7171#issuecomment-868353013)
> > Here is the list:
> >
> > 1.
> >
> >
> >
> > https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-jdbc-1.5.x-plugin
> > 2.
> >
> >
> >
> > https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-3.x-plugin
> > 3.
> >
> >
> >
> > https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.0.x-plugin
> > 4.
> >
> >
> >
> > https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.1.0-plugin
> > 5.
> >
> >
> >
> > https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-RC3-plugin
> > 6.
> >
> >
> >
> > https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-plugin
> > 7.
> >
> >
> >
> > https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/shardingsphere-5.0.0-beta-plugin
> >
> >
> > Since the sharding-jdbc-1.5.x and the sharding-sphere-3.x have no longer
> > been maintained, I propose to
> > remove sharding-jdbc-1.5.x-plugin
> > <
> >
> >
> > https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-jdbc-1.5.x-plugin
> >
> > and sharding-sphere-3.x-plugin
> > <
> >
> >
> > https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-3.x-plugin
> >
> > from
> > SkyWalking's master branch to reduce maintenance costs.
> >
> > ------------------
> >
> > Sincerely,
> > Weijie Wu (TeslaCN)
> > Apache ShardingSphere
> >
> >
> >
Re: [DISCUSS] Remove ShardingSphere SkyWalking agent plugins for
legacy version from SkyWalking's master branch
Posted by Sheng Wu <wu...@gmail.com>.
Hi Weijie
Could you submit a pull request to remove all these?
Sheng Wu 吴晟
Twitter, wusheng1108
Juan Pan <pa...@apache.org> 于2021年7月12日周一 下午12:19写道：
> +1 from me.
>
>
>
>
> ------------------------------------------------------------------------------
> Juan Pan(Trista), Apache ShardingSphere PMC
> Twitter, @trista86934690
>
>
> On 07/11/2021 19:05，吴伟杰<wu...@apache.org> wrote：
> Hi
>
> Consider the 3.x is a GA release, and the plugins for 4.x RC are no
> longer needed because there are already plugins for 4.x GA.
> Our primary conclusion is removing the following plugins:
> 1. sharding-jdbc-1.5.x-plugin
> 2. sharding-sphere-4.x-rc3-plugin
> 3. sharding-sphere-4.x-plugin (This is for RC1 and RC2)
>
> If no one objects, I will clear up the codebase next weekend.
>
> ------------------
>
> Sincerely,
> Weijie Wu (TeslaCN)
> Apache ShardingSphere
>
> Sheng Wu <wu...@gmail.com> 于2021年7月11日周日 上午9:12写道：
>
> Hi
>
> Do we have a conclusion? And Weijie, could you follow this and clear up the
> codebase?
>
> Sheng Wu 吴晟
> Twitter, wusheng1108
>
>
> Juan Pan <pa...@apache.org> 于2021年7月1日周四 上午9:11写道：
>
> Hi,
>
>
> I have no clear idea on how each plugin is different, but they are
> actually different.
> Considering users' preference for different releases,My +1 to keep the 4.0
> and 4.1 GA versions.
>
>
>
>
>
> ------------------------------------------------------------------------------
> Juan Pan(Trista), Apache ShardingSphere PMC, Apache brpc (Incubating) IPMC
> Twitter, @trista86934690
>
>
> On 07/1/2021 07:50，Sheng Wu<wu...@gmail.com> wrote：
> Hi
>
> ```
> 3.
>
>
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.0.x-plugin
> 4.
>
>
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.1.0-plugin
> 5.
>
>
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-RC3-plugin
> 6.
>
>
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-plugin
> ```
>
> What is the difference between 4.x and 4.0/4.1 plugins? Could some of them
> be removed?
> And RC3 should be removed as you have plugins for GA releases already.
>
> Sheng Wu 吴晟
> Twitter, wusheng1108
>
>
> 吴伟杰 <wu...@apache.org> 于2021年6月30日周三 下午11:19写道：
>
> Hi All,
>
> SkyWalking's master branch hosts 7 agent plugins for different versions of
> ShardingSphere.
> They think the plugins are too many. (
> https://github.com/apache/skywalking/pull/7171#issuecomment-868353013)
> Here is the list:
>
> 1.
>
>
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-jdbc-1.5.x-plugin
> 2.
>
>
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-3.x-plugin
> 3.
>
>
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.0.x-plugin
> 4.
>
>
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.1.0-plugin
> 5.
>
>
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-RC3-plugin
> 6.
>
>
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-plugin
> 7.
>
>
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/shardingsphere-5.0.0-beta-plugin
>
>
> Since the sharding-jdbc-1.5.x and the sharding-sphere-3.x have no longer
> been maintained, I propose to
> remove sharding-jdbc-1.5.x-plugin
> <
>
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-jdbc-1.5.x-plugin
>
> and sharding-sphere-3.x-plugin
> <
>
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-3.x-plugin
>
> from
> SkyWalking's master branch to reduce maintenance costs.
>
> ------------------
>
> Sincerely,
> Weijie Wu (TeslaCN)
> Apache ShardingSphere
>
>
>
Re: [DISCUSS] Remove ShardingSphere SkyWalking agent plugins for
legacy version from SkyWalking's master branch
Posted by Juan Pan <pa...@apache.org>.
+1 from me.
------------------------------------------------------------------------------
Juan Pan(Trista), Apache ShardingSphere PMC
Twitter, @trista86934690
On 07/11/2021 19:05，吴伟杰<wu...@apache.org> wrote：
Hi
Consider the 3.x is a GA release, and the plugins for 4.x RC are no
longer needed because there are already plugins for 4.x GA.
Our primary conclusion is removing the following plugins:
1. sharding-jdbc-1.5.x-plugin
2. sharding-sphere-4.x-rc3-plugin
3. sharding-sphere-4.x-plugin (This is for RC1 and RC2)
If no one objects, I will clear up the codebase next weekend.
------------------
Sincerely,
Weijie Wu (TeslaCN)
Apache ShardingSphere
Sheng Wu <wu...@gmail.com> 于2021年7月11日周日 上午9:12写道：
Hi
Do we have a conclusion? And Weijie, could you follow this and clear up the
codebase?
Sheng Wu 吴晟
Twitter, wusheng1108
Juan Pan <pa...@apache.org> 于2021年7月1日周四 上午9:11写道：
Hi,
I have no clear idea on how each plugin is different, but they are
actually different.
Considering users' preference for different releases,My +1 to keep the 4.0
and 4.1 GA versions.
------------------------------------------------------------------------------
Juan Pan(Trista), Apache ShardingSphere PMC, Apache brpc (Incubating) IPMC
Twitter, @trista86934690
On 07/1/2021 07:50，Sheng Wu<wu...@gmail.com> wrote：
Hi
```
3.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.0.x-plugin
4.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.1.0-plugin
5.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-RC3-plugin
6.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-plugin
```
What is the difference between 4.x and 4.0/4.1 plugins? Could some of them
be removed?
And RC3 should be removed as you have plugins for GA releases already.
Sheng Wu 吴晟
Twitter, wusheng1108
吴伟杰 <wu...@apache.org> 于2021年6月30日周三 下午11:19写道：
Hi All,
SkyWalking's master branch hosts 7 agent plugins for different versions of
ShardingSphere.
They think the plugins are too many. (
https://github.com/apache/skywalking/pull/7171#issuecomment-868353013)
Here is the list:
1.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-jdbc-1.5.x-plugin
2.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-3.x-plugin
3.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.0.x-plugin
4.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.1.0-plugin
5.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-RC3-plugin
6.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-plugin
7.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/shardingsphere-5.0.0-beta-plugin
Since the sharding-jdbc-1.5.x and the sharding-sphere-3.x have no longer
been maintained, I propose to
remove sharding-jdbc-1.5.x-plugin
<
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-jdbc-1.5.x-plugin
and sharding-sphere-3.x-plugin
<
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-3.x-plugin
from
SkyWalking's master branch to reduce maintenance costs.
------------------
Sincerely,
Weijie Wu (TeslaCN)
Apache ShardingSphere
Re: [DISCUSS] Remove ShardingSphere SkyWalking agent plugins for
legacy version from SkyWalking's master branch
Posted by 吴伟杰 <wu...@apache.org>.
Hi
Consider the 3.x is a GA release, and the plugins for 4.x RC are no
longer needed because there are already plugins for 4.x GA.
Our primary conclusion is removing the following plugins:
1. sharding-jdbc-1.5.x-plugin
2. sharding-sphere-4.x-rc3-plugin
3. sharding-sphere-4.x-plugin (This is for RC1 and RC2)
If no one objects, I will clear up the codebase next weekend.
------------------
Sincerely,
Weijie Wu (TeslaCN)
Apache ShardingSphere
Sheng Wu <wu...@gmail.com> 于2021年7月11日周日 上午9:12写道：
>
> Hi
>
> Do we have a conclusion? And Weijie, could you follow this and clear up the
> codebase?
>
> Sheng Wu 吴晟
> Twitter, wusheng1108
>
>
> Juan Pan <pa...@apache.org> 于2021年7月1日周四 上午9:11写道：
>
> > Hi,
> >
> >
> > I have no clear idea on how each plugin is different, but they are
> > actually different.
> > Considering users' preference for different releases,My +1 to keep the 4.0
> > and 4.1 GA versions.
> >
> >
> >
> >
> > ------------------------------------------------------------------------------
> > Juan Pan(Trista), Apache ShardingSphere PMC, Apache brpc (Incubating) IPMC
> > Twitter, @trista86934690
> >
> >
> > On 07/1/2021 07:50，Sheng Wu<wu...@gmail.com> wrote：
> > Hi
> >
> > ```
> > 3.
> >
> >
> > https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.0.x-plugin
> > 4.
> >
> >
> > https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.1.0-plugin
> > 5.
> >
> >
> > https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-RC3-plugin
> > 6.
> >
> >
> > https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-plugin
> > ```
> >
> > What is the difference between 4.x and 4.0/4.1 plugins? Could some of them
> > be removed?
> > And RC3 should be removed as you have plugins for GA releases already.
> >
> > Sheng Wu 吴晟
> > Twitter, wusheng1108
> >
> >
> > 吴伟杰 <wu...@apache.org> 于2021年6月30日周三 下午11:19写道：
> >
> > Hi All,
> >
> > SkyWalking's master branch hosts 7 agent plugins for different versions of
> > ShardingSphere.
> > They think the plugins are too many. (
> > https://github.com/apache/skywalking/pull/7171#issuecomment-868353013)
> > Here is the list:
> >
> > 1.
> >
> >
> > https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-jdbc-1.5.x-plugin
> > 2.
> >
> >
> > https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-3.x-plugin
> > 3.
> >
> >
> > https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.0.x-plugin
> > 4.
> >
> >
> > https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.1.0-plugin
> > 5.
> >
> >
> > https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-RC3-plugin
> > 6.
> >
> >
> > https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-plugin
> > 7.
> >
> >
> > https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/shardingsphere-5.0.0-beta-plugin
> >
> >
> > Since the sharding-jdbc-1.5.x and the sharding-sphere-3.x have no longer
> > been maintained, I propose to
> > remove sharding-jdbc-1.5.x-plugin
> > <
> >
> > https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-jdbc-1.5.x-plugin
> >
> > and sharding-sphere-3.x-plugin
> > <
> >
> > https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-3.x-plugin
> >
> > from
> > SkyWalking's master branch to reduce maintenance costs.
> >
> > ------------------
> >
> > Sincerely,
> > Weijie Wu (TeslaCN)
> > Apache ShardingSphere
> >
> >
Re: [DISCUSS] Remove ShardingSphere SkyWalking agent plugins for
legacy version from SkyWalking's master branch
Posted by Sheng Wu <wu...@gmail.com>.
Hi
Do we have a conclusion? And Weijie, could you follow this and clear up the
codebase?
Sheng Wu 吴晟
Twitter, wusheng1108
Juan Pan <pa...@apache.org> 于2021年7月1日周四 上午9:11写道：
> Hi,
>
>
> I have no clear idea on how each plugin is different, but they are
> actually different.
> Considering users' preference for different releases,My +1 to keep the 4.0
> and 4.1 GA versions.
>
>
>
>
> ------------------------------------------------------------------------------
> Juan Pan(Trista), Apache ShardingSphere PMC, Apache brpc (Incubating) IPMC
> Twitter, @trista86934690
>
>
> On 07/1/2021 07:50，Sheng Wu<wu...@gmail.com> wrote：
> Hi
>
> ```
> 3.
>
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.0.x-plugin
> 4.
>
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.1.0-plugin
> 5.
>
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-RC3-plugin
> 6.
>
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-plugin
> ```
>
> What is the difference between 4.x and 4.0/4.1 plugins? Could some of them
> be removed?
> And RC3 should be removed as you have plugins for GA releases already.
>
> Sheng Wu 吴晟
> Twitter, wusheng1108
>
>
> 吴伟杰 <wu...@apache.org> 于2021年6月30日周三 下午11:19写道：
>
> Hi All,
>
> SkyWalking's master branch hosts 7 agent plugins for different versions of
> ShardingSphere.
> They think the plugins are too many. (
> https://github.com/apache/skywalking/pull/7171#issuecomment-868353013)
> Here is the list:
>
> 1.
>
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-jdbc-1.5.x-plugin
> 2.
>
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-3.x-plugin
> 3.
>
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.0.x-plugin
> 4.
>
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.1.0-plugin
> 5.
>
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-RC3-plugin
> 6.
>
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-plugin
> 7.
>
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/shardingsphere-5.0.0-beta-plugin
>
>
> Since the sharding-jdbc-1.5.x and the sharding-sphere-3.x have no longer
> been maintained, I propose to
> remove sharding-jdbc-1.5.x-plugin
> <
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-jdbc-1.5.x-plugin
>
> and sharding-sphere-3.x-plugin
> <
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-3.x-plugin
>
> from
> SkyWalking's master branch to reduce maintenance costs.
>
> ------------------
>
> Sincerely,
> Weijie Wu (TeslaCN)
> Apache ShardingSphere
>
>
Re: [DISCUSS] Remove ShardingSphere SkyWalking agent plugins for
legacy version from SkyWalking's master branch
Posted by Juan Pan <pa...@apache.org>.
Hi,
I have no clear idea on how each plugin is different, but they are actually different.
Considering users' preference for different releases,My +1 to keep the 4.0 and 4.1 GA versions.
------------------------------------------------------------------------------
Juan Pan(Trista), Apache ShardingSphere PMC, Apache brpc (Incubating) IPMC
Twitter, @trista86934690
On 07/1/2021 07:50，Sheng Wu<wu...@gmail.com> wrote：
Hi
```
3.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.0.x-plugin
4.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.1.0-plugin
5.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-RC3-plugin
6.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-plugin
```
What is the difference between 4.x and 4.0/4.1 plugins? Could some of them
be removed?
And RC3 should be removed as you have plugins for GA releases already.
Sheng Wu 吴晟
Twitter, wusheng1108
吴伟杰 <wu...@apache.org> 于2021年6月30日周三 下午11:19写道：
Hi All,
SkyWalking's master branch hosts 7 agent plugins for different versions of
ShardingSphere.
They think the plugins are too many. (
https://github.com/apache/skywalking/pull/7171#issuecomment-868353013)
Here is the list:
1.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-jdbc-1.5.x-plugin
2.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-3.x-plugin
3.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.0.x-plugin
4.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.1.0-plugin
5.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-RC3-plugin
6.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-plugin
7.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/shardingsphere-5.0.0-beta-plugin
Since the sharding-jdbc-1.5.x and the sharding-sphere-3.x have no longer
been maintained, I propose to
remove sharding-jdbc-1.5.x-plugin
<
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-jdbc-1.5.x-plugin
and sharding-sphere-3.x-plugin
<
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-3.x-plugin
from
SkyWalking's master branch to reduce maintenance costs.
------------------
Sincerely,
Weijie Wu (TeslaCN)
Apache ShardingSphere
Re: [DISCUSS] Remove ShardingSphere SkyWalking agent plugins for
legacy version from SkyWalking's master branch
Posted by Sheng Wu <wu...@gmail.com>.
Hi
```
3.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.0.x-plugin
4.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.1.0-plugin
5.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-RC3-plugin
6.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-plugin
```
What is the difference between 4.x and 4.0/4.1 plugins? Could some of them
be removed?
And RC3 should be removed as you have plugins for GA releases already.
Sheng Wu 吴晟
Twitter, wusheng1108
吴伟杰 <wu...@apache.org> 于2021年6月30日周三 下午11:19写道：
> Hi All,
>
> SkyWalking's master branch hosts 7 agent plugins for different versions of
> ShardingSphere.
> They think the plugins are too many. (
> https://github.com/apache/skywalking/pull/7171#issuecomment-868353013)
> Here is the list:
>
> 1.
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-jdbc-1.5.x-plugin
> 2.
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-3.x-plugin
> 3.
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.0.x-plugin
> 4.
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.1.0-plugin
> 5.
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-RC3-plugin
> 6.
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-4.x-plugin
> 7.
>
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/shardingsphere-5.0.0-beta-plugin
>
>
> Since the sharding-jdbc-1.5.x and the sharding-sphere-3.x have no longer
> been maintained, I propose to
> remove sharding-jdbc-1.5.x-plugin
> <
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-jdbc-1.5.x-plugin
> >
> and sharding-sphere-3.x-plugin
> <
> https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/sharding-sphere-3.x-plugin
> >
> from
> SkyWalking's master branch to reduce maintenance costs.
>
> ------------------
>
> Sincerely,
> Weijie Wu (TeslaCN)
> Apache ShardingSphere
>