[jira] [Commented] (LUCENE-5961) FunctionValues.exist(int) isn't returning false in cases where it should for many "math" based value sources

["Hoss Man (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-5961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14139672#comment-14139672 ] 

Hoss Man commented on LUCENE-5961:
----------------------------------

discovered this while working on tests for SOLR-6354.

As part of that issue i'm updating StatsComponentTest.java with some commented out assertions that can be re-enabled once this issue is resolved (grep for "SOLR-6354")

> FunctionValues.exist(int) isn't returning false in cases where it should for many "math" based value sources
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-5961
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5961
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Hoss Man
>         Attachments: LUCENE-5961.patch
>
>
> The FunctionValues class contains an exist(int doc) method with a default implementation that returns true - field based DocValues override this method as appropriate, but most of the "function" based subclasses in the code (typically anonymous subclasses of "FloatDocValues") don't override this method when wrapping other ValueSources.
> So for example: the FunctionValues returned by ProductFloatFunction.getValues() will say that a value exists for any doc, even if that ProductFloatFunction wraps two FloatFieldSources that don't exist for any docs



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org