You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "Cole-Greer (via GitHub)" <gi...@apache.org> on 2023/07/25 21:21:07 UTC
[GitHub] [tinkerpop] Cole-Greer opened a new pull request, #2159: Add deprecation notice for Neo4j-Gremlin
Cole-Greer opened a new pull request, #2159:
URL: https://github.com/apache/tinkerpop/pull/2159
Based on dev list discussion, a decision was made to deprecate neo4j-gremlin. It will remain in the repo for foreseeable future and we will continue to maintain compatibility when possible. If the effort to maintain neo4j-gremlin becomes unreasonable in the future, a decision to remove it may be made at that time.
See DISCUSS thread on the dev list for more details: (https://lists.apache.org/thread/lxn4s9fs8rzggm0jlnffnphfpqnpn3h8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] Cole-Greer commented on pull request #2159: Add deprecation notice for Neo4j-Gremlin
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #2159:
URL: https://github.com/apache/tinkerpop/pull/2159#issuecomment-1652867449
I've rebased this to 3.5-dev in response to some users raising concerns about security issues with some of the transitive dependencies in neo4j-gremlin. Deprecating in all branches will give users a more accurate impression of the current level of support for the module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] kenhuuu commented on pull request #2159: Add deprecation notice for Neo4j-Gremlin
Posted by "kenhuuu (via GitHub)" <gi...@apache.org>.
kenhuuu commented on PR #2159:
URL: https://github.com/apache/tinkerpop/pull/2159#issuecomment-1652194432
You might want to add a deprecation tag to LabelBiPredicate static class in LabelP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] vkagamlyk commented on pull request #2159: Add deprecation notice for Neo4j-Gremlin
Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on PR #2159:
URL: https://github.com/apache/tinkerpop/pull/2159#issuecomment-1654530930
VOTE +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] codecov-commenter commented on pull request #2159: Add deprecation notice for Neo4j-Gremlin
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2159:
URL: https://github.com/apache/tinkerpop/pull/2159#issuecomment-1650611506
## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2159?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#2159](https://app.codecov.io/gh/apache/tinkerpop/pull/2159?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f8ab367) into [master](https://app.codecov.io/gh/apache/tinkerpop/commit/127bf02c84618aed5777d115dfc8780aed17e55d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (127bf02) will **increase** coverage by `0.38%`.
> Report is 2 commits behind head on master.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #2159 +/- ##
============================================
+ Coverage 75.85% 76.24% +0.38%
- Complexity 12525 12532 +7
============================================
Files 1039 1015 -24
Lines 63433 59892 -3541
Branches 7028 7028
============================================
- Hits 48120 45667 -2453
+ Misses 12694 11780 -914
+ Partials 2619 2445 -174
```
| [Files Changed](https://app.codecov.io/gh/apache/tinkerpop/pull/2159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...erpop/gremlin/neo4j/jsr223/Neo4jGremlinPlugin.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bmVvNGotZ3JlbWxpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdGlua2VycG9wL2dyZW1saW4vbmVvNGovanNyMjIzL05lbzRqR3JlbWxpblBsdWdpbi5qYXZh) | `0.00% <ø> (ø)` | |
| [...kerpop/gremlin/neo4j/process/traversal/LabelP.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bmVvNGotZ3JlbWxpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdGlua2VycG9wL2dyZW1saW4vbmVvNGovcHJvY2Vzcy90cmF2ZXJzYWwvTGFiZWxQLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ess/traversal/step/sideEffect/CypherStartStep.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bmVvNGotZ3JlbWxpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdGlua2VycG9wL2dyZW1saW4vbmVvNGovcHJvY2Vzcy90cmF2ZXJzYWwvc3RlcC9zaWRlRWZmZWN0L0N5cGhlclN0YXJ0U3RlcC5qYXZh) | `0.00% <ø> (ø)` | |
| [...cess/traversal/step/sideEffect/Neo4jGraphStep.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bmVvNGotZ3JlbWxpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdGlua2VycG9wL2dyZW1saW4vbmVvNGovcHJvY2Vzcy90cmF2ZXJzYWwvc3RlcC9zaWRlRWZmZWN0L05lbzRqR3JhcGhTdGVwLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../strategy/optimization/Neo4jGraphStepStrategy.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bmVvNGotZ3JlbWxpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdGlua2VycG9wL2dyZW1saW4vbmVvNGovcHJvY2Vzcy90cmF2ZXJzYWwvc3RyYXRlZ3kvb3B0aW1pemF0aW9uL05lbzRqR3JhcGhTdGVwU3RyYXRlZ3kuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...remlin/neo4j/process/util/Neo4jCypherIterator.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bmVvNGotZ3JlbWxpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdGlua2VycG9wL2dyZW1saW4vbmVvNGovcHJvY2Vzcy91dGlsL05lbzRqQ3lwaGVySXRlcmF0b3IuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...e/tinkerpop/gremlin/neo4j/structure/Neo4jEdge.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bmVvNGotZ3JlbWxpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdGlua2VycG9wL2dyZW1saW4vbmVvNGovc3RydWN0dXJlL05lbzRqRWRnZS5qYXZh) | `0.00% <ø> (ø)` | |
| [...inkerpop/gremlin/neo4j/structure/Neo4jElement.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bmVvNGotZ3JlbWxpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdGlua2VycG9wL2dyZW1saW4vbmVvNGovc3RydWN0dXJlL05lbzRqRWxlbWVudC5qYXZh) | `0.00% <ø> (ø)` | |
| [.../tinkerpop/gremlin/neo4j/structure/Neo4jGraph.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bmVvNGotZ3JlbWxpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdGlua2VycG9wL2dyZW1saW4vbmVvNGovc3RydWN0dXJlL05lbzRqR3JhcGguamF2YQ==) | `0.00% <ø> (ø)` | |
| [...p/gremlin/neo4j/structure/Neo4jGraphVariables.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-bmVvNGotZ3JlbWxpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdGlua2VycG9wL2dyZW1saW4vbmVvNGovc3RydWN0dXJlL05lbzRqR3JhcGhWYXJpYWJsZXMuamF2YQ==) | `0.00% <ø> (ø)` | |
| ... and [4 more](https://app.codecov.io/gh/apache/tinkerpop/pull/2159?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [31 files with indirect coverage changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2159/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] Cole-Greer merged pull request #2159: Add deprecation notice for Neo4j-Gremlin
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer merged PR #2159:
URL: https://github.com/apache/tinkerpop/pull/2159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org