You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2018/02/22 17:15:52 UTC
[kudu-CR](branch-1.5.x) Optionally advance safe time with non-write operations
David Ribeiro Alves has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9396
Change subject: Optionally advance safe time with non-write operations
......................................................................
Optionally advance safe time with non-write operations
We currently have a problem with safe time advancement when
there are no write messages in the WAL. Because of KUDU-2233,
NO_OP and CHANGE_CONFIG messages are not guaranteed to have
monotonic timestamps, which forced us to ignore them in the
past. This can cause compactions to execute with a timestamp
that is in the beginning of time, causing corruption or crashes.
This patch enables us to advance safe time for all messages
if a flag a set.
Once KUDU-2233 is solved we can flip the flag or remove it
altogether.
Change-Id: I99de2284ba1626581c6e0770c823fd1ba714c1d7
---
M src/kudu/tablet/tablet_bootstrap.cc
1 file changed, 11 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/9396/1
--
To view, visit http://gerrit.cloudera.org:8080/9396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I99de2284ba1626581c6e0770c823fd1ba714c1d7
Gerrit-Change-Number: 9396
Gerrit-PatchSet: 1
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
[kudu-CR](branch-1.5.x) Optionally advance safe time with non-write operations
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9396 )
Change subject: Optionally advance safe time with non-write operations
......................................................................
Patch Set 2: Verified+1
unrelated java failure
--
To view, visit http://gerrit.cloudera.org:8080/9396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I99de2284ba1626581c6e0770c823fd1ba714c1d7
Gerrit-Change-Number: 9396
Gerrit-PatchSet: 2
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 22 Feb 2018 18:53:47 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.5.x) Optionally advance safe time with non-write operations
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9396 )
Change subject: Optionally advance safe time with non-write operations
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9396/1/src/kudu/tablet/tablet_bootstrap.cc
File src/kudu/tablet/tablet_bootstrap.cc:
http://gerrit.cloudera.org:8080/#/c/9396/1/src/kudu/tablet/tablet_bootstrap.cc@91
PS1, Line 91: DEFINE_bool(advance_safe_time_with_non_write_ops, false,
> probably should be marked unsafe or experimental or something if we plan to
Done
--
To view, visit http://gerrit.cloudera.org:8080/9396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I99de2284ba1626581c6e0770c823fd1ba714c1d7
Gerrit-Change-Number: 9396
Gerrit-PatchSet: 1
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 22 Feb 2018 17:51:28 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.5.x) Optionally advance safe time with non-write operations
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9396
to look at the new patch set (#2).
Change subject: Optionally advance safe time with non-write operations
......................................................................
Optionally advance safe time with non-write operations
We currently have a problem with safe time advancement when
there are no write messages in the WAL. Because of KUDU-2233,
NO_OP and CHANGE_CONFIG messages are not guaranteed to have
monotonic timestamps, which forced us to ignore them in the
past. This can cause compactions to execute with a timestamp
that is in the beginning of time, causing corruption or crashes.
This patch enables us to advance safe time for all messages
if a flag a set.
Once KUDU-2233 is solved we can flip the flag or remove it
altogether.
Change-Id: I99de2284ba1626581c6e0770c823fd1ba714c1d7
---
M src/kudu/tablet/tablet_bootstrap.cc
1 file changed, 12 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/9396/2
--
To view, visit http://gerrit.cloudera.org:8080/9396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I99de2284ba1626581c6e0770c823fd1ba714c1d7
Gerrit-Change-Number: 9396
Gerrit-PatchSet: 2
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.5.x) Optionally advance safe time with non-write operations
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9396 )
Change subject: Optionally advance safe time with non-write operations
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I99de2284ba1626581c6e0770c823fd1ba714c1d7
Gerrit-Change-Number: 9396
Gerrit-PatchSet: 2
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 22 Feb 2018 19:22:10 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.5.x) Optionally advance safe time with non-write operations
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9396 )
Change subject: Optionally advance safe time with non-write operations
......................................................................
Patch Set 2:
the build failed because of python, c++ tests passed. monitoring it to see whether it was a temp flake.
--
To view, visit http://gerrit.cloudera.org:8080/9396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I99de2284ba1626581c6e0770c823fd1ba714c1d7
Gerrit-Change-Number: 9396
Gerrit-PatchSet: 2
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 22 Feb 2018 17:53:51 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.5.x) Optionally advance safe time with non-write operations
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has removed a vote on this change.
Change subject: Optionally advance safe time with non-write operations
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/9396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I99de2284ba1626581c6e0770c823fd1ba714c1d7
Gerrit-Change-Number: 9396
Gerrit-PatchSet: 2
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.5.x) Optionally advance safe time with non-write operations
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9396 )
Change subject: Optionally advance safe time with non-write operations
......................................................................
Optionally advance safe time with non-write operations
We currently have a problem with safe time advancement when
there are no write messages in the WAL. Because of KUDU-2233,
NO_OP and CHANGE_CONFIG messages are not guaranteed to have
monotonic timestamps, which forced us to ignore them in the
past. This can cause compactions to execute with a timestamp
that is in the beginning of time, causing corruption or crashes.
This patch enables us to advance safe time for all messages
if a flag a set.
Once KUDU-2233 is solved we can flip the flag or remove it
altogether.
Change-Id: I99de2284ba1626581c6e0770c823fd1ba714c1d7
Reviewed-on: http://gerrit.cloudera.org:8080/9396
Tested-by: David Ribeiro Alves <da...@gmail.com>
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/tablet/tablet_bootstrap.cc
1 file changed, 12 insertions(+), 6 deletions(-)
Approvals:
David Ribeiro Alves: Verified
Todd Lipcon: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I99de2284ba1626581c6e0770c823fd1ba714c1d7
Gerrit-Change-Number: 9396
Gerrit-PatchSet: 3
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.5.x) Optionally advance safe time with non-write operations
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/9396 )
Change subject: Optionally advance safe time with non-write operations
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9396/1/src/kudu/tablet/tablet_bootstrap.cc
File src/kudu/tablet/tablet_bootstrap.cc:
http://gerrit.cloudera.org:8080/#/c/9396/1/src/kudu/tablet/tablet_bootstrap.cc@91
PS1, Line 91: DEFINE_bool(advance_safe_time_with_non_write_ops, false,
probably should be marked unsafe or experimental or something if we plan to remove it soon
--
To view, visit http://gerrit.cloudera.org:8080/9396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.5.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I99de2284ba1626581c6e0770c823fd1ba714c1d7
Gerrit-Change-Number: 9396
Gerrit-PatchSet: 1
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Thu, 22 Feb 2018 17:24:30 +0000
Gerrit-HasComments: Yes