You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Arshad Matin <ar...@gmail.com> on 2015/05/13 15:27:48 UTC

Review Request 34165: LENS-553:Move Lens compile version to Java 7

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34165/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-553
    https://issues.apache.org/jira/browse/LENS-553


Repository: lens


Description
-------

LENS-553:Move Lens compile version to Java 7


Diffs
-----

  lens-dist/src/deb/control/client-control/control 51d3c9f63ed5a4393ce5962a4c62f2a75429bc9d 
  lens-dist/src/deb/control/server-control/control b8f733345731f051b55fe1ba273cfb9eafaa954c 
  pom.xml 6a62afffcebd0947c3bcfb62591cf6ed64e9ee3d 
  src/site/apt/admin/deployment.apt 7fbeb5654def4ca9652c0faf5f53c698b9867029 
  src/site/apt/developer/contribute.apt 77bdc2b7e208a7348a9fab9a88274d6acc25fa79 

Diff: https://reviews.apache.org/r/34165/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 25.161 s]
[INFO] Lens ............................................... SUCCESS [ 19.966 s]
[INFO] Lens API ........................................... SUCCESS [ 38.817 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 38.130 s]
[INFO] Lens Cube .......................................... SUCCESS [05:07 min]
[INFO] Lens DB storage .................................... SUCCESS [ 40.759 s]
[INFO] Lens Query Library ................................. SUCCESS [ 32.711 s]
[INFO] Lens Hive Driver ................................... SUCCESS [06:13 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [01:03 min]
[INFO] Lens Server ........................................ SUCCESS [21:44 min]
[INFO] Lens client ........................................ SUCCESS [01:09 min]
[INFO] Lens CLI ........................................... SUCCESS [07:28 min]
[INFO] Lens Examples ...................................... SUCCESS [ 24.290 s]
[INFO] Lens Distribution .................................. SUCCESS [ 33.952 s]
[INFO] Lens ML Lib ........................................ SUCCESS [06:26 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 23.310 s]
[INFO] Lens Regression .................................... SUCCESS [ 17.311 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 54:07 min
[INFO] Finished at: 2015-05-13T18:50:03+05:30
[INFO] Final Memory: 125M/496M
[INFO] ------------------------------------------------------------------------


Thanks,

Arshad Matin


Re: Review Request 34165: LENS-553:Move Lens compile version to Java 7

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34165/#review83714
-----------------------------------------------------------



pom.xml
<https://reviews.apache.org/r/34165/#comment134755>

    enunciate jdk activation also can be moved to 1.7+.
    
    Change would be required in main pom and lens-server pom.



src/site/apt/admin/deployment.apt
<https://reviews.apache.org/r/34165/#comment134753>

    We can update doc here, as deployment on java8 works fine and is certified.



src/site/apt/developer/contribute.apt
<https://reviews.apache.org/r/34165/#comment134756>

    README.md also needs update.


- Amareshwari Sriramadasu


On May 13, 2015, 1:27 p.m., Arshad Matin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34165/
> -----------------------------------------------------------
> 
> (Updated May 13, 2015, 1:27 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-553
>     https://issues.apache.org/jira/browse/LENS-553
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> LENS-553:Move Lens compile version to Java 7
> 
> 
> Diffs
> -----
> 
>   lens-dist/src/deb/control/client-control/control 51d3c9f63ed5a4393ce5962a4c62f2a75429bc9d 
>   lens-dist/src/deb/control/server-control/control b8f733345731f051b55fe1ba273cfb9eafaa954c 
>   pom.xml 6a62afffcebd0947c3bcfb62591cf6ed64e9ee3d 
>   src/site/apt/admin/deployment.apt 7fbeb5654def4ca9652c0faf5f53c698b9867029 
>   src/site/apt/developer/contribute.apt 77bdc2b7e208a7348a9fab9a88274d6acc25fa79 
> 
> Diff: https://reviews.apache.org/r/34165/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 25.161 s]
> [INFO] Lens ............................................... SUCCESS [ 19.966 s]
> [INFO] Lens API ........................................... SUCCESS [ 38.817 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 38.130 s]
> [INFO] Lens Cube .......................................... SUCCESS [05:07 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 40.759 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 32.711 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [06:13 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [01:03 min]
> [INFO] Lens Server ........................................ SUCCESS [21:44 min]
> [INFO] Lens client ........................................ SUCCESS [01:09 min]
> [INFO] Lens CLI ........................................... SUCCESS [07:28 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 24.290 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 33.952 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [06:26 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 23.310 s]
> [INFO] Lens Regression .................................... SUCCESS [ 17.311 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 54:07 min
> [INFO] Finished at: 2015-05-13T18:50:03+05:30
> [INFO] Final Memory: 125M/496M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Arshad Matin
> 
>


Re: Review Request 34165: LENS-553:Move Lens compile version to Java 7

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34165/#review83748
-----------------------------------------------------------



README.md
<https://reviews.apache.org/r/34165/#comment134808>

    Build does not pass with JDK(1.8) yet. Only runtime is certified.



src/site/apt/developer/contribute.apt
<https://reviews.apache.org/r/34165/#comment134809>

    Same as read me. Build does not pass with java8 yet. only runtime works.


- Amareshwari Sriramadasu


On May 14, 2015, 11:06 a.m., Arshad Matin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34165/
> -----------------------------------------------------------
> 
> (Updated May 14, 2015, 11:06 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-553
>     https://issues.apache.org/jira/browse/LENS-553
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> LENS-553:Move Lens compile version to Java 7
> 
> 
> Diffs
> -----
> 
>   README.md c9163eeabb425dee827b365944b6ae9b86fb57a2 
>   lens-dist/src/deb/control/client-control/control 51d3c9f63ed5a4393ce5962a4c62f2a75429bc9d 
>   lens-dist/src/deb/control/server-control/control b8f733345731f051b55fe1ba273cfb9eafaa954c 
>   lens-server/pom.xml 75d16180c3960b218f95e7054feb533c13f0530c 
>   pom.xml 6a62afffcebd0947c3bcfb62591cf6ed64e9ee3d 
>   src/site/apt/admin/deployment.apt 7fbeb5654def4ca9652c0faf5f53c698b9867029 
>   src/site/apt/developer/contribute.apt 77bdc2b7e208a7348a9fab9a88274d6acc25fa79 
> 
> Diff: https://reviews.apache.org/r/34165/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 25.161 s]
> [INFO] Lens ............................................... SUCCESS [ 19.966 s]
> [INFO] Lens API ........................................... SUCCESS [ 38.817 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 38.130 s]
> [INFO] Lens Cube .......................................... SUCCESS [05:07 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 40.759 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 32.711 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [06:13 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [01:03 min]
> [INFO] Lens Server ........................................ SUCCESS [21:44 min]
> [INFO] Lens client ........................................ SUCCESS [01:09 min]
> [INFO] Lens CLI ........................................... SUCCESS [07:28 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 24.290 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 33.952 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [06:26 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 23.310 s]
> [INFO] Lens Regression .................................... SUCCESS [ 17.311 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 54:07 min
> [INFO] Finished at: 2015-05-13T18:50:03+05:30
> [INFO] Final Memory: 125M/496M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Arshad Matin
> 
>


Re: Review Request 34165: LENS-553:Move Lens compile version to Java 7

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34165/#review83751
-----------------------------------------------------------

Ship it!


Ship It!

- Amareshwari Sriramadasu


On May 14, 2015, 11:44 a.m., Arshad Matin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34165/
> -----------------------------------------------------------
> 
> (Updated May 14, 2015, 11:44 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-553
>     https://issues.apache.org/jira/browse/LENS-553
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> LENS-553:Move Lens compile version to Java 7
> 
> 
> Diffs
> -----
> 
>   README.md c9163eeabb425dee827b365944b6ae9b86fb57a2 
>   lens-dist/src/deb/control/client-control/control 51d3c9f63ed5a4393ce5962a4c62f2a75429bc9d 
>   lens-dist/src/deb/control/server-control/control b8f733345731f051b55fe1ba273cfb9eafaa954c 
>   lens-server/pom.xml 75d16180c3960b218f95e7054feb533c13f0530c 
>   pom.xml 6a62afffcebd0947c3bcfb62591cf6ed64e9ee3d 
>   src/site/apt/admin/deployment.apt 7fbeb5654def4ca9652c0faf5f53c698b9867029 
>   src/site/apt/developer/contribute.apt 77bdc2b7e208a7348a9fab9a88274d6acc25fa79 
> 
> Diff: https://reviews.apache.org/r/34165/diff/
> 
> 
> Testing
> -------
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 25.161 s]
> [INFO] Lens ............................................... SUCCESS [ 19.966 s]
> [INFO] Lens API ........................................... SUCCESS [ 38.817 s]
> [INFO] Lens API for server and extensions ................. SUCCESS [ 38.130 s]
> [INFO] Lens Cube .......................................... SUCCESS [05:07 min]
> [INFO] Lens DB storage .................................... SUCCESS [ 40.759 s]
> [INFO] Lens Query Library ................................. SUCCESS [ 32.711 s]
> [INFO] Lens Hive Driver ................................... SUCCESS [06:13 min]
> [INFO] Lens Driver for JDBC ............................... SUCCESS [01:03 min]
> [INFO] Lens Server ........................................ SUCCESS [21:44 min]
> [INFO] Lens client ........................................ SUCCESS [01:09 min]
> [INFO] Lens CLI ........................................... SUCCESS [07:28 min]
> [INFO] Lens Examples ...................................... SUCCESS [ 24.290 s]
> [INFO] Lens Distribution .................................. SUCCESS [ 33.952 s]
> [INFO] Lens ML Lib ........................................ SUCCESS [06:26 min]
> [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 23.310 s]
> [INFO] Lens Regression .................................... SUCCESS [ 17.311 s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 54:07 min
> [INFO] Finished at: 2015-05-13T18:50:03+05:30
> [INFO] Final Memory: 125M/496M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Arshad Matin
> 
>


Re: Review Request 34165: LENS-553:Move Lens compile version to Java 7

Posted by Arshad Matin <ar...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34165/
-----------------------------------------------------------

(Updated May 14, 2015, 11:44 a.m.)


Review request for lens.


Bugs: LENS-553
    https://issues.apache.org/jira/browse/LENS-553


Repository: lens


Description
-------

LENS-553:Move Lens compile version to Java 7


Diffs (updated)
-----

  README.md c9163eeabb425dee827b365944b6ae9b86fb57a2 
  lens-dist/src/deb/control/client-control/control 51d3c9f63ed5a4393ce5962a4c62f2a75429bc9d 
  lens-dist/src/deb/control/server-control/control b8f733345731f051b55fe1ba273cfb9eafaa954c 
  lens-server/pom.xml 75d16180c3960b218f95e7054feb533c13f0530c 
  pom.xml 6a62afffcebd0947c3bcfb62591cf6ed64e9ee3d 
  src/site/apt/admin/deployment.apt 7fbeb5654def4ca9652c0faf5f53c698b9867029 
  src/site/apt/developer/contribute.apt 77bdc2b7e208a7348a9fab9a88274d6acc25fa79 

Diff: https://reviews.apache.org/r/34165/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 25.161 s]
[INFO] Lens ............................................... SUCCESS [ 19.966 s]
[INFO] Lens API ........................................... SUCCESS [ 38.817 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 38.130 s]
[INFO] Lens Cube .......................................... SUCCESS [05:07 min]
[INFO] Lens DB storage .................................... SUCCESS [ 40.759 s]
[INFO] Lens Query Library ................................. SUCCESS [ 32.711 s]
[INFO] Lens Hive Driver ................................... SUCCESS [06:13 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [01:03 min]
[INFO] Lens Server ........................................ SUCCESS [21:44 min]
[INFO] Lens client ........................................ SUCCESS [01:09 min]
[INFO] Lens CLI ........................................... SUCCESS [07:28 min]
[INFO] Lens Examples ...................................... SUCCESS [ 24.290 s]
[INFO] Lens Distribution .................................. SUCCESS [ 33.952 s]
[INFO] Lens ML Lib ........................................ SUCCESS [06:26 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 23.310 s]
[INFO] Lens Regression .................................... SUCCESS [ 17.311 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 54:07 min
[INFO] Finished at: 2015-05-13T18:50:03+05:30
[INFO] Final Memory: 125M/496M
[INFO] ------------------------------------------------------------------------


Thanks,

Arshad Matin


Re: Review Request 34165: LENS-553:Move Lens compile version to Java 7

Posted by Arshad Matin <ar...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34165/
-----------------------------------------------------------

(Updated May 14, 2015, 11:06 a.m.)


Review request for lens.


Bugs: LENS-553
    https://issues.apache.org/jira/browse/LENS-553


Repository: lens


Description
-------

LENS-553:Move Lens compile version to Java 7


Diffs (updated)
-----

  README.md c9163eeabb425dee827b365944b6ae9b86fb57a2 
  lens-dist/src/deb/control/client-control/control 51d3c9f63ed5a4393ce5962a4c62f2a75429bc9d 
  lens-dist/src/deb/control/server-control/control b8f733345731f051b55fe1ba273cfb9eafaa954c 
  lens-server/pom.xml 75d16180c3960b218f95e7054feb533c13f0530c 
  pom.xml 6a62afffcebd0947c3bcfb62591cf6ed64e9ee3d 
  src/site/apt/admin/deployment.apt 7fbeb5654def4ca9652c0faf5f53c698b9867029 
  src/site/apt/developer/contribute.apt 77bdc2b7e208a7348a9fab9a88274d6acc25fa79 

Diff: https://reviews.apache.org/r/34165/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 25.161 s]
[INFO] Lens ............................................... SUCCESS [ 19.966 s]
[INFO] Lens API ........................................... SUCCESS [ 38.817 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 38.130 s]
[INFO] Lens Cube .......................................... SUCCESS [05:07 min]
[INFO] Lens DB storage .................................... SUCCESS [ 40.759 s]
[INFO] Lens Query Library ................................. SUCCESS [ 32.711 s]
[INFO] Lens Hive Driver ................................... SUCCESS [06:13 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [01:03 min]
[INFO] Lens Server ........................................ SUCCESS [21:44 min]
[INFO] Lens client ........................................ SUCCESS [01:09 min]
[INFO] Lens CLI ........................................... SUCCESS [07:28 min]
[INFO] Lens Examples ...................................... SUCCESS [ 24.290 s]
[INFO] Lens Distribution .................................. SUCCESS [ 33.952 s]
[INFO] Lens ML Lib ........................................ SUCCESS [06:26 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 23.310 s]
[INFO] Lens Regression .................................... SUCCESS [ 17.311 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 54:07 min
[INFO] Finished at: 2015-05-13T18:50:03+05:30
[INFO] Final Memory: 125M/496M
[INFO] ------------------------------------------------------------------------


Thanks,

Arshad Matin


Re: Review Request 34165: LENS-553:Move Lens compile version to Java 7

Posted by Arshad Matin <ar...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34165/
-----------------------------------------------------------

(Updated May 14, 2015, 11:06 a.m.)


Review request for lens.


Bugs: LENS-553
    https://issues.apache.org/jira/browse/LENS-553


Repository: lens


Description
-------

LENS-553:Move Lens compile version to Java 7


Diffs (updated)
-----

  README.md c9163eeabb425dee827b365944b6ae9b86fb57a2 
  lens-dist/src/deb/control/client-control/control 51d3c9f63ed5a4393ce5962a4c62f2a75429bc9d 
  lens-dist/src/deb/control/server-control/control b8f733345731f051b55fe1ba273cfb9eafaa954c 
  lens-server/pom.xml 75d16180c3960b218f95e7054feb533c13f0530c 
  pom.xml 6a62afffcebd0947c3bcfb62591cf6ed64e9ee3d 
  src/site/apt/admin/deployment.apt 7fbeb5654def4ca9652c0faf5f53c698b9867029 
  src/site/apt/developer/contribute.apt 77bdc2b7e208a7348a9fab9a88274d6acc25fa79 

Diff: https://reviews.apache.org/r/34165/diff/


Testing
-------

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules .............................. SUCCESS [ 25.161 s]
[INFO] Lens ............................................... SUCCESS [ 19.966 s]
[INFO] Lens API ........................................... SUCCESS [ 38.817 s]
[INFO] Lens API for server and extensions ................. SUCCESS [ 38.130 s]
[INFO] Lens Cube .......................................... SUCCESS [05:07 min]
[INFO] Lens DB storage .................................... SUCCESS [ 40.759 s]
[INFO] Lens Query Library ................................. SUCCESS [ 32.711 s]
[INFO] Lens Hive Driver ................................... SUCCESS [06:13 min]
[INFO] Lens Driver for JDBC ............................... SUCCESS [01:03 min]
[INFO] Lens Server ........................................ SUCCESS [21:44 min]
[INFO] Lens client ........................................ SUCCESS [01:09 min]
[INFO] Lens CLI ........................................... SUCCESS [07:28 min]
[INFO] Lens Examples ...................................... SUCCESS [ 24.290 s]
[INFO] Lens Distribution .................................. SUCCESS [ 33.952 s]
[INFO] Lens ML Lib ........................................ SUCCESS [06:26 min]
[INFO] Lens ML Ext Distribution ........................... SUCCESS [ 23.310 s]
[INFO] Lens Regression .................................... SUCCESS [ 17.311 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 54:07 min
[INFO] Finished at: 2015-05-13T18:50:03+05:30
[INFO] Final Memory: 125M/496M
[INFO] ------------------------------------------------------------------------


Thanks,

Arshad Matin