You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/08/12 22:14:28 UTC

[GitHub] [beam] steveniemitz commented on pull request #15327: [BEAM-12754] Only call getValue once per field per row

steveniemitz commented on pull request #15327:
URL: https://github.com/apache/beam/pull/15327#issuecomment-898002838


   > If you want to do a larger refactor (and intelliJ should make this easy), you can rename getValues() -> getRawValues()
   
   I could be convinced to do that in a follow up :P
   
   I chose to use a simple for loop to avoid some intermediate object allocations w/ IntStream, Collect, etc, since this is a pretty hot-path method.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org