You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "dweiss (via GitHub)" <gi...@apache.org> on 2026/09/25 09:01:04 UTC
[PR] Go back to the official google-java-format distribution [lucene]
dweiss opened a new pull request, #16713:
URL: https://github.com/apache/lucene/pull/16713
...now that it supports markdown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Go back to the official google-java-format distribution [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss merged PR #16713:
URL: https://github.com/apache/lucene/pull/16713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Go back to the official google-java-format distribution [lucene]
Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on code in PR #16713:
URL: https://github.com/apache/lucene/pull/16713#discussion_r4103094129
##########
build-tools/build-infra/src/main/java/org/apache/lucene/gradle/plugins/spotless/ParentGoogleJavaFormatTask.java:
##########
@@ -67,6 +67,13 @@ abstract class ParentGoogleJavaFormatTask extends DefaultTask {
@PathSensitive(PathSensitivity.RELATIVE)
public abstract ConfigurableFileCollection getSourceFiles();
+ /**
+ * The formatter's coordinates (module and version). Any change invalidates all cached file states
+ * so that every source file is processed again with the new formatter.
+ */
+ @Input
+ public abstract Property<String> getFormatterVersion();
+
Review Comment:
We need the task to try to reprocess source files if the formatter changes. Piggybacking this on top of the upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org