You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "LoganZhuZzz (via GitHub)" <gi...@apache.org> on 2024/12/17 08:39:09 UTC
[PR] KAFKA-18278: Correct name and description for run-gradle step [kafka]
LoganZhuZzz opened a new pull request, #18223:
URL: https://github.com/apache/kafka/pull/18223
*The name and description for the `run-gradle` step were updated to make them clearer and more consistent with the overall workflow. The updated names now better describe the purpose of the step.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18278: Correct name and description for run-gradle step [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah merged PR #18223:
URL: https://github.com/apache/kafka/pull/18223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18278: Correct name and description for run-gradle step [kafka]
Posted by "LoganZhuZzz (via GitHub)" <gi...@apache.org>.
LoganZhuZzz commented on code in PR #18223:
URL: https://github.com/apache/kafka/pull/18223#discussion_r1891061518
##########
.github/actions/run-gradle/action.yml:
##########
@@ -16,8 +16,8 @@
# under the License.
#
---
-name: "Gradle Setup"
-description: "Setup Java and Gradle"
+name: "Run Gradle Tests"
Review Comment:
It makes more sense. I’ve made the change accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18278: Correct name and description for run-gradle step [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on code in PR #18223:
URL: https://github.com/apache/kafka/pull/18223#discussion_r1888567351
##########
.github/actions/run-gradle/action.yml:
##########
@@ -16,8 +16,8 @@
# under the License.
#
---
-name: "Gradle Setup"
-description: "Setup Java and Gradle"
+name: "Gradle Test Setup"
Review Comment:
This was a mis-copied name from our setup-gradle action. It should just be "Run Tests with Gradle" or similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18278: Correct name and description for run-gradle step [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #18223:
URL: https://github.com/apache/kafka/pull/18223#discussion_r1890245365
##########
.github/actions/run-gradle/action.yml:
##########
@@ -16,8 +16,8 @@
# under the License.
#
---
-name: "Gradle Setup"
-description: "Setup Java and Gradle"
+name: "Run Gradle Tests"
Review Comment:
Could you please use "Run Tests with Gradle"? It makes more sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org