[GitHub] [incubator-paimon] wg1026688210 commented on a diff in pull request #887: [hive] Avoid using hive own FileSystem to access the location of paimon table when using HiveCatalog

["wg1026688210 (via GitHub)" <gi...@apache.org>]

wg1026688210 commented on code in PR #887:
URL: https://github.com/apache/incubator-paimon/pull/887#discussion_r1174520543


##########
paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveCatalogFactory.java:
##########
@@ -69,7 +69,7 @@ public Catalog create(FileIO fileIO, Path warehouse, CatalogContext context) {
         // always using user-set parameters overwrite hive-site.xml parameters
         context.options().toMap().forEach(hiveConf::set);
         hiveConf.set(HiveConf.ConfVars.METASTOREURIS.varname, uri);
-        hiveConf.set(HiveConf.ConfVars.METASTOREWAREHOUSE.varname, warehouse.toUri().toString());
+        hiveConf.set(CatalogOptions.WAREHOUSE.key(), warehouse.toUri().toString());

Review Comment:
   It's better for passing warehouse to HiveCatalog for a better readable indeed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org