[GitHub] [iceberg] RussellSpitzer commented on pull request #1350: Update Static Analysis WIP

[GitBox <gi...@apache.org>]

RussellSpitzer commented on pull request #1350:
URL: https://github.com/apache/iceberg/pull/1350#issuecomment-677764061


   So the Issue with Right Curly is that in previous versions of check style it was broken.
   We use these directive
   
           <module name="RightCurly"> <!-- Java Style Guide: Nonempty blocks: K & R style -->
               <property name="option" value="alone"/>
               <property name="tokens" value="CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, LITERAL_WHILE, STATIC_INIT, INSTANCE_INIT"/>
           </module>
   
   On Constructors, which means every usage of private Constructor(){} is illegal. It just wasn't marked previously.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org