[GitHub] [zeppelin] zjffdu commented on a change in pull request #3797: [ZEPPELIN-4851]. Add property to flink interpreter to allow replace the yarn address

[GitBox <gi...@apache.org>]

zjffdu commented on a change in pull request #3797:
URL: https://github.com/apache/zeppelin/pull/3797#discussion_r439302961



##########
File path: flink/interpreter/src/main/scala/org/apache/zeppelin/flink/FlinkScalaInterpreter.scala
##########
@@ -829,6 +835,12 @@ class FlinkScalaInterpreter(val properties: Properties) {
       }
     }
   }
+
+  private def replaceYarnAddress(webURL: String, yarnAddress: String): String = {
+    val pattern = "(http://.*:\\d+)(/.*)".r

Review comment:
       @alexott  `URL` doesn't expose set method. So it is not easy to construct URL with components, however I fixed the https issue and also add unit tests




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org