You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/08 18:11:44 UTC

[GitHub] feng-tao commented on a change in pull request #4401: [AIRFLOW-3596] Clean up undefined template variables.

feng-tao commented on a change in pull request #4401: [AIRFLOW-3596] Clean up undefined template variables.
URL: https://github.com/apache/airflow/pull/4401#discussion_r246098191
 
 

 ##########
 File path: airflow/www/views.py
 ##########
 @@ -681,9 +682,17 @@ def dag_details(self, session=None):
             .group_by(TI.state)\
             .all()
 
+        active_runs = models.DagRun.find(
+            dag_id=dag.dag_id,
+            state=State.RUNNING,
 
 Review comment:
   thanks. I go back and check https://github.com/apache/airflow/blob/master/airflow/models/__init__.py#L3560 which we define active_run to only running state. Initially, I thought scheduled would be one of them as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services