You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/16 09:59:04 UTC
[GitHub] [spark] LuciferYang opened a new pull request #35540: [SPARK-37783][SQL][FOLLOWUP] Enable tail-recursion wherever possible
LuciferYang opened a new pull request #35540:
URL: https://github.com/apache/spark/pull/35540
### What changes were proposed in this pull request?
This pr adds `@scala.annotation.tailrec` inspected by IDE (IntelliJ)
### Why are the changes needed?
To improve performance.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Pass GA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #35540: [SPARK-37783][SQL][FOLLOWUP] Enable tail-recursion wherever possible
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35540:
URL: https://github.com/apache/spark/pull/35540#issuecomment-1042520552
Manual re-trigger CI, waiting for results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #35540: [SPARK-37783][SQL][FOLLOWUP] Enable tail-recursion wherever possible
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35540:
URL: https://github.com/apache/spark/pull/35540#issuecomment-1042611781
@dongjoon-hyun @HyukjinKwon GA Passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #35540: [SPARK-37783][SQL][FOLLOWUP] Enable tail-recursion wherever possible
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35540:
URL: https://github.com/apache/spark/pull/35540#issuecomment-1041313153
cc @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #35540: [SPARK-37783][SQL][FOLLOWUP] Enable tail-recursion wherever possible
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #35540:
URL: https://github.com/apache/spark/pull/35540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #35540: [SPARK-37783][SQL][FOLLOWUP] Enable tail-recursion wherever possible
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #35540:
URL: https://github.com/apache/spark/pull/35540#issuecomment-1042638653
thanks all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on a change in pull request #35540: [SPARK-37783][SQL][FOLLOWUP] Enable tail-recursion wherever possible
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on a change in pull request #35540:
URL: https://github.com/apache/spark/pull/35540#discussion_r807748639
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnType.scala
##########
@@ -833,7 +833,7 @@ private[columnar] object ColumnType {
case arr: ArrayType => ARRAY(arr)
case map: MapType => MAP(map)
case struct: StructType => STRUCT(struct)
- case udt: UserDefinedType[_] => apply(udt.sqlType)
+ case udt: UserDefinedType[_] => ColumnType(udt.sqlType)
Review comment:
This change because IntelliJ doesn't think this is a `@tailrec`:
<img width="794" alt="image" src="https://user-images.githubusercontent.com/1475305/154241095-920b0044-d065-402d-bfd7-11fa56f8c9af.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35540: [SPARK-37783][SQL][FOLLOWUP] Enable tail-recursion wherever possible
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35540:
URL: https://github.com/apache/spark/pull/35540#issuecomment-1042005127
Could you add an empty commit to re-trigger CI, @LuciferYang ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35540: [SPARK-37783][SQL][FOLLOWUP] Enable tail-recursion wherever possible
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35540:
URL: https://github.com/apache/spark/pull/35540#issuecomment-1042627485
Yep. Thanks, @LuciferYang .
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org