You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@iotdb.apache.org by "sunjincheng (Jira)" <ji...@apache.org> on 2021/03/30 10:32:00 UTC
[jira] [Commented] (IOTDB-1265) cluster package refactor missed
necessary change
[ https://issues.apache.org/jira/browse/IOTDB-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311379#comment-17311379 ]
sunjincheng commented on IOTDB-1265:
------------------------------------
Thanks for report this issue [~jamber001]! feel free to open the PR :)
> cluster package refactor missed necessary change
> ------------------------------------------------
>
> Key: IOTDB-1265
> URL: https://issues.apache.org/jira/browse/IOTDB-1265
> Project: Apache IoTDB
> Issue Type: Bug
> Components: Cluster
> Reporter: Bo Zhang
> Priority: Major
> Fix For: 0.12.0
>
>
> There was ever below change：
> =============================================================
> commit 64c11bc259cfc948286b8bf299792380766deb25
> Author: wangchao316 <66...@users.noreply.github.com>
> Date: Tue Mar 23 20:54:44 2021 +0800
> IOTDB-1255 refactor cluster package and jar name (#2892)
> diff --git a/cluster/pom.xml b/cluster/pom.xml
> index 1d2969321..9a15a0daa 100644
> — a/cluster/pom.xml
> +++ b/cluster/pom.xml
> @@ -27,7 +27,7 @@
> <version>0.12.0-SNAPSHOT</version>
> <relativePath>../pom.xml</relativePath>
> </parent>
> - <artifactId>cluster</artifactId>
> + <artifactId>iotdb-cluster</artifactId>
> <name>cluster</name>
> <properties>
> <cluster.test.skip>false</cluster.test.skip>
> ============================================================
> but above commit missed below 2 points' change
> =============================================================
> vi distribution/pom.xml
> <dependency>
> <groupId>org.apache.iotdb</groupId>
> <artifactId>cluster</artifactId> //should be <artifactId>iotdb-cluster</artifactId>
> <version>${project.version}</version>
> <type>zip</type>
> </dependency>
> vi distribution/src/assembly/cluster.xml
> <dependencySets>
> <dependencySet>
> <includes>
> <include>*:cluster:zip:*</include> //should be <include>*:iotdb-cluster:zip:*</include>
> <include>*:iotdb-cli:zip:*</include>
> </includes>
> =============================================================
> When you run cmd "mvn clean pacakge",
> above bug will cause final package(apache-iotdb-xxx-cluster-bin.zip) contains old files that are from cluster-xxx.zip（from Maven repo).
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)