[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #18987: [fix][broker] Copy proto command fields into final variables in ServerCnx

[GitBox <gi...@apache.org>]

michaeljmarshall commented on code in PR #18987:
URL: https://github.com/apache/pulsar/pull/18987#discussion_r1053650914


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -1634,6 +1629,7 @@ protected void handleAck(CommandAck ack) {
         final boolean hasRequestId = ack.hasRequestId();
         final long requestId = hasRequestId ? ack.getRequestId() : 0;
         final long consumerId = ack.getConsumerId();
+        final CommandAck finalAck = getBrokerService().getInterceptor() != null ? new CommandAck().copyFrom(ack) : null;

Review Comment:
   You are right, great catch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org