[GitHub] [flink] zhijiangW opened a new pull request #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods

[GitBox <gi...@apache.org>]

zhijiangW opened a new pull request #8529: [FLINK-12603][network] Refactor InputGate interface to remove unnecessary methods
URL: https://github.com/apache/flink/pull/8529
 
 
   ## What is the purpose of the change
   
   *In order to make abstract `InputGate` simple for extending new implementations in shuffle service architecture, we could remove unnecessary methods from it.*
   
   *Currently `InputGate#getOwningTaskName` is only used for debugging log in `BarrierBuffer` and `StreamInputProcessor`. This task name could be got from `Environment#getTaskInfo` and then be passed into the constructor of `BarrierBuffer/StreamInputProcessor` for use.*
   
   *`InputGate#getPageSize` is only used for `BarrierBuffer` constructor. We could remove this method and the page size could also be got form task manager configuration instead.*
   
   ## Brief change log
   
     - *Add the full task name in the `TaskInfo`*
     - *Remove `getOwningTaskName` and `getPageSize` from `InputGate` abstract methods*
     - *Refactor the related process to get task name and page size for `BarrierBuffer` and `StreamInputProcessor`*
   
   ## Verifying this change
   
   covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services