You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2017/03/01 14:49:59 UTC

svn commit: r1784956 - /tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.java

Author: markt
Date: Wed Mar  1 14:49:59 2017
New Revision: 1784956

URL: http://svn.apache.org/viewvc?rev=1784956&view=rev
Log:
Add a test case based on the report in bug 60788.

Modified:
    tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.java

Modified: tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.java?rev=1784956&r1=1784955&r2=1784956&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.java (original)
+++ tomcat/trunk/test/org/apache/tomcat/util/http/TestCookies.java Wed Mar  1 14:49:59 2017
@@ -470,6 +470,33 @@ public class TestCookies {
         test(true, "$Version=1;x\tx=yyy,foo=bar;a=b", FOO, A);
     }
 
+    @Test
+    public void testBug60788Rfc6265() {
+        doTestBug60788(true);
+    }
+
+    @Test
+    public void testBug60788Rfc2109() {
+        doTestBug60788(false);
+    }
+
+    private void doTestBug60788(boolean useRfc6265) {
+        Cookie expected = new Cookie("userId", "foo");
+        expected.setVersion(1);
+        if (useRfc6265) {
+            expected.setDomain("\"www.example.org\"");
+            expected.setPath("\"/\"");
+        } else {
+            // The legacy processor removes the quotes for domain and path
+            expected.setDomain("www.example.org");
+            expected.setPath("/");
+        }
+
+        test(useRfc6265, "$Version=\"1\"; userId=\"foo\";$Path=\"/\";$Domain=\"www.example.org\"",
+                expected);
+    }
+
+
     private void test(boolean useRfc6265, String header, Cookie... expected) {
         MimeHeaders mimeHeaders = new MimeHeaders();
         ServerCookies serverCookies = new ServerCookies(4);



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org