[GitHub] QiuMM commented on a change in pull request #6540: add close method in Cache interface

[GitBox <gi...@apache.org>]

QiuMM commented on a change in pull request #6540: add close method in Cache interface
URL: https://github.com/apache/incubator-druid/pull/6540#discussion_r238655426
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/client/cache/HybridCache.java
 ##########
 @@ -131,6 +134,15 @@ public void close(String namespace)
     level2.close(namespace);
 
 Review comment:
   It's related to this PR, and this `close` method is not a `Closeable` method which can be handled by try-with-resources idiom.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org