You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Jarcec <ja...@jarcec.net> on 2011/11/17 19:39:28 UTC
Review Request: SQOOP-393: Class SqoopOptions was not properly moved
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2874/
-----------------------------------------------------------
Review request for Sqoop and Arvind Prabhakar.
Summary
-------
I've moved the functionality like we did with other classes.
This addresses bug SQOOP-393.
https://issues.apache.org/jira/browse/SQOOP-393
Diffs
-----
/src/java/com/cloudera/sqoop/SqoopOptions.java 1201319
/src/java/org/apache/sqoop/SqoopOptions.java 1201319
Diff: https://reviews.apache.org/r/2874/diff
Testing
-------
I've passed basic tests.
Thanks,
Jarek
Re: Review Request: SQOOP-393: Class SqoopOptions was not properly moved
Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2874/#review3334
-----------------------------------------------------------
Ship it!
+1
Thanks for the patch Jarcec. Please attach the patch to the JIRA for commit.
- Arvind
On 2011-11-17 18:47:44, Jarek Jarcec wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2874/
> -----------------------------------------------------------
>
> (Updated 2011-11-17 18:47:44)
>
>
> Review request for Sqoop and Arvind Prabhakar.
>
>
> Summary
> -------
>
> I've moved the functionality like we did with other classes.
>
>
> This addresses bug SQOOP-393.
> https://issues.apache.org/jira/browse/SQOOP-393
>
>
> Diffs
> -----
>
> /src/java/com/cloudera/sqoop/SqoopOptions.java 1201319
> /src/java/org/apache/sqoop/SqoopOptions.java 1201319
>
> Diff: https://reviews.apache.org/r/2874/diff
>
>
> Testing
> -------
>
> I've passed basic tests.
>
>
> Thanks,
>
> Jarek
>
>
Re: Review Request: SQOOP-393: Class SqoopOptions was not properly moved
Posted by Jarek Jarcec <ja...@jarcec.net>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2874/
-----------------------------------------------------------
(Updated 2011-11-17 18:47:44.428152)
Review request for Sqoop and Arvind Prabhakar.
Changes
-------
Fixed checkstyle violations.
Summary
-------
I've moved the functionality like we did with other classes.
This addresses bug SQOOP-393.
https://issues.apache.org/jira/browse/SQOOP-393
Diffs (updated)
-----
/src/java/com/cloudera/sqoop/SqoopOptions.java 1201319
/src/java/org/apache/sqoop/SqoopOptions.java 1201319
Diff: https://reviews.apache.org/r/2874/diff
Testing
-------
I've passed basic tests.
Thanks,
Jarek