You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/07/30 20:47:03 UTC
[GitHub] [buildstream-plugins] nanonyme opened a new pull request, #21: Use build-dir by default
nanonyme opened a new pull request, #21:
URL: https://github.com/apache/buildstream-plugins/pull/21
This is a reasonable default for majority of projects using autotools
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] nanonyme commented on a diff in pull request #21: Use build-dir by default
Posted by GitBox <gi...@apache.org>.
nanonyme commented on code in PR #21:
URL: https://github.com/apache/buildstream-plugins/pull/21#discussion_r933947931
##########
src/buildstream_plugins/elements/autotools.yaml:
##########
@@ -93,20 +94,39 @@ config:
- |
%{autogen}
- |
- %{configure}
+ if [ -n "%{build-dir}" ]; then
+ mkdir %{build-dir}
+ pushd %{build-dir}
+ %{configure}
+ popd
+ else
+ %{configure}
+ fi
# Commands for building the software
#
build-commands:
- |
- %{make}
+ if [ -n "%{build-dir}" ]; then
+ pushd %{build-dir}
+ %{make}
+ popd
Review Comment:
It seems the more portable way to do this is using subshells (it would actually be nice if bst2 wrapped the parts in subshells before passing the command forward)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] gtristan commented on a diff in pull request #21: Use build-dir by default
Posted by GitBox <gi...@apache.org>.
gtristan commented on code in PR #21:
URL: https://github.com/apache/buildstream-plugins/pull/21#discussion_r933946945
##########
src/buildstream_plugins/elements/autotools.yaml:
##########
@@ -93,20 +94,39 @@ config:
- |
%{autogen}
- |
- %{configure}
+ if [ -n "%{build-dir}" ]; then
+ mkdir %{build-dir}
+ pushd %{build-dir}
+ %{configure}
+ popd
+ else
+ %{configure}
+ fi
# Commands for building the software
#
build-commands:
- |
- %{make}
+ if [ -n "%{build-dir}" ]; then
+ pushd %{build-dir}
+ %{make}
+ popd
Review Comment:
> As far as I've seen bst2 does not.
This is an important detail we have thus far omitted from the [porting guide](https://docs.buildstream.build/master/porting_project.html).
Opening https://github.com/apache/buildstream/issues/1708 to track this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] nanonyme commented on a diff in pull request #21: Use build-dir by default
Posted by GitBox <gi...@apache.org>.
nanonyme commented on code in PR #21:
URL: https://github.com/apache/buildstream-plugins/pull/21#discussion_r933947931
##########
src/buildstream_plugins/elements/autotools.yaml:
##########
@@ -93,20 +94,39 @@ config:
- |
%{autogen}
- |
- %{configure}
+ if [ -n "%{build-dir}" ]; then
+ mkdir %{build-dir}
+ pushd %{build-dir}
+ %{configure}
+ popd
+ else
+ %{configure}
+ fi
# Commands for building the software
#
build-commands:
- |
- %{make}
+ if [ -n "%{build-dir}" ]; then
+ pushd %{build-dir}
+ %{make}
+ popd
Review Comment:
It seems the more portable way to do this is using subshells (it would actually be nice if bst2 wrapped the parts in subshells before passing the command forward but ti's perfectly possible to handle on plugin level too)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] gtristan commented on pull request #21: Enable setting build-dir
Posted by GitBox <gi...@apache.org>.
gtristan commented on PR #21:
URL: https://github.com/apache/buildstream-plugins/pull/21#issuecomment-1200380054
> Is this still an API break if build-dir is not set by default?
Technically yes, because this patch will still change cache keys for `autotools` elements regardless of whether they buy into `builddir != srcdir`.
That said, there are other factors which will require cache key changes in advance of 2.0. I personally feel that it will be okay to break cache keys until 2.0 for some last minute improvements, but this hasn't been formally discussed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] nanonyme commented on pull request #21: Enable setting build-dir
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #21:
URL: https://github.com/apache/buildstream-plugins/pull/21#issuecomment-1200461386
Incidentally build-dir support is also the last part that makes sense upstream at all from freedesktop-sdk configuration. Much of the rest is special stuff like supporting cross-compilation of stack from another OS. That doesn't make sense in this repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] nanonyme commented on a diff in pull request #21: Use build-dir by default
Posted by GitBox <gi...@apache.org>.
nanonyme commented on code in PR #21:
URL: https://github.com/apache/buildstream-plugins/pull/21#discussion_r933946184
##########
src/buildstream_plugins/elements/autotools.yaml:
##########
@@ -93,20 +94,39 @@ config:
- |
%{autogen}
- |
- %{configure}
+ if [ -n "%{build-dir}" ]; then
+ mkdir %{build-dir}
+ pushd %{build-dir}
+ %{configure}
+ popd
+ else
+ %{configure}
+ fi
# Commands for building the software
#
build-commands:
- |
- %{make}
+ if [ -n "%{build-dir}" ]; then
+ pushd %{build-dir}
+ %{make}
+ popd
Review Comment:
I'm not sure if it works correctly though. The point is that element author is supposed to be able to do `make -C subcomponent` and this works *inside build-dir*. So we need to change working directory outside make.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] nanonyme commented on a diff in pull request #21: Use build-dir by default
Posted by GitBox <gi...@apache.org>.
nanonyme commented on code in PR #21:
URL: https://github.com/apache/buildstream-plugins/pull/21#discussion_r933945771
##########
src/buildstream_plugins/elements/autotools.yaml:
##########
@@ -93,20 +94,39 @@ config:
- |
%{autogen}
- |
- %{configure}
+ if [ -n "%{build-dir}" ]; then
+ mkdir %{build-dir}
+ pushd %{build-dir}
+ %{configure}
+ popd
+ else
+ %{configure}
+ fi
# Commands for building the software
#
build-commands:
- |
- %{make}
+ if [ -n "%{build-dir}" ]; then
+ pushd %{build-dir}
+ %{make}
+ popd
Review Comment:
FWIW this is what we're doing right now in freedesktop-sdk, this is mostly copy-paste from that. The difference is what freedesktop-sdk does relies on the fact that bst1 resets working directory between script configure-commands, build-commands and install-commands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] nanonyme commented on a diff in pull request #21: Use build-dir by default
Posted by GitBox <gi...@apache.org>.
nanonyme commented on code in PR #21:
URL: https://github.com/apache/buildstream-plugins/pull/21#discussion_r933944653
##########
src/buildstream_plugins/elements/autotools.yaml:
##########
@@ -93,20 +94,39 @@ config:
- |
%{autogen}
- |
- %{configure}
+ if [ -n "%{build-dir}" ]; then
+ mkdir %{build-dir}
+ pushd %{build-dir}
+ %{configure}
+ popd
+ else
+ %{configure}
+ fi
# Commands for building the software
#
build-commands:
- |
- %{make}
+ if [ -n "%{build-dir}" ]; then
+ pushd %{build-dir}
+ %{make}
+ popd
Review Comment:
Yeah, I guess it's clearer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] nanonyme commented on pull request #21: Enable setting build-dir
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #21:
URL: https://github.com/apache/buildstream-plugins/pull/21#issuecomment-1206757716
I am closing this. I think it might be reasonable for downstream to have quite minimal approach for build-dir through modifying configure, make and make-install variables which are API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] nanonyme commented on a diff in pull request #21: Use build-dir by default
Posted by GitBox <gi...@apache.org>.
nanonyme commented on code in PR #21:
URL: https://github.com/apache/buildstream-plugins/pull/21#discussion_r933944703
##########
src/buildstream_plugins/elements/autotools.yaml:
##########
@@ -93,20 +94,39 @@ config:
- |
%{autogen}
- |
- %{configure}
+ if [ -n "%{build-dir}" ]; then
+ mkdir %{build-dir}
+ pushd %{build-dir}
+ %{configure}
+ popd
+ else
+ %{configure}
+ fi
Review Comment:
autogen typically needs to be run from conf dir, configure is run from build-dir.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] nanonyme commented on a diff in pull request #21: Enable setting build-dir
Posted by GitBox <gi...@apache.org>.
nanonyme commented on code in PR #21:
URL: https://github.com/apache/buildstream-plugins/pull/21#discussion_r933953103
##########
src/buildstream_plugins/elements/autotools.yaml:
##########
@@ -93,20 +94,39 @@ config:
- |
%{autogen}
- |
- %{configure}
+ if [ -n "%{build-dir}" ]; then
+ mkdir %{build-dir}
+ pushd %{build-dir}
+ %{configure}
+ popd
+ else
+ %{configure}
+ fi
# Commands for building the software
#
build-commands:
- |
- %{make}
+ if [ -n "%{build-dir}" ]; then
+ pushd %{build-dir}
+ %{make}
+ popd
Review Comment:
Right, subshell strategy definitely works. What is iffy here is whether it would be cleaner to pre-create commands-subdir if it doesn't exist, run autogen in subshell in conf-root (where it normally has to be run) and tell consumer that they can set build-dir through `command-subdir: build-dir`. This would not require new API but would again break cache keys...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] nanonyme commented on a diff in pull request #21: Use build-dir by default
Posted by GitBox <gi...@apache.org>.
nanonyme commented on code in PR #21:
URL: https://github.com/apache/buildstream-plugins/pull/21#discussion_r933947931
##########
src/buildstream_plugins/elements/autotools.yaml:
##########
@@ -93,20 +94,39 @@ config:
- |
%{autogen}
- |
- %{configure}
+ if [ -n "%{build-dir}" ]; then
+ mkdir %{build-dir}
+ pushd %{build-dir}
+ %{configure}
+ popd
+ else
+ %{configure}
+ fi
# Commands for building the software
#
build-commands:
- |
- %{make}
+ if [ -n "%{build-dir}" ]; then
+ pushd %{build-dir}
+ %{make}
+ popd
Review Comment:
It seems the more portable way to do this is using subshells
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] nanonyme commented on a diff in pull request #21: Use build-dir by default
Posted by GitBox <gi...@apache.org>.
nanonyme commented on code in PR #21:
URL: https://github.com/apache/buildstream-plugins/pull/21#discussion_r933945771
##########
src/buildstream_plugins/elements/autotools.yaml:
##########
@@ -93,20 +94,39 @@ config:
- |
%{autogen}
- |
- %{configure}
+ if [ -n "%{build-dir}" ]; then
+ mkdir %{build-dir}
+ pushd %{build-dir}
+ %{configure}
+ popd
+ else
+ %{configure}
+ fi
# Commands for building the software
#
build-commands:
- |
- %{make}
+ if [ -n "%{build-dir}" ]; then
+ pushd %{build-dir}
+ %{make}
+ popd
Review Comment:
FWIW this is what we're doing right now in freedesktop-sdk, this is mostly copy-paste from that. The difference is what freedesktop-sdk does relies on the fact that bst1 resets working directory between script configure-commands, build-commands and install-commands. As far as I've seen bst2 does not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] nanonyme commented on a diff in pull request #21: Use build-dir by default
Posted by GitBox <gi...@apache.org>.
nanonyme commented on code in PR #21:
URL: https://github.com/apache/buildstream-plugins/pull/21#discussion_r933944653
##########
src/buildstream_plugins/elements/autotools.yaml:
##########
@@ -93,20 +94,39 @@ config:
- |
%{autogen}
- |
- %{configure}
+ if [ -n "%{build-dir}" ]; then
+ mkdir %{build-dir}
+ pushd %{build-dir}
+ %{configure}
+ popd
+ else
+ %{configure}
+ fi
# Commands for building the software
#
build-commands:
- |
- %{make}
+ if [ -n "%{build-dir}" ]; then
+ pushd %{build-dir}
+ %{make}
+ popd
Review Comment:
Yeah, I guss it's clearer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] gtristan commented on pull request #21: Use build-dir by default
Posted by GitBox <gi...@apache.org>.
gtristan commented on PR #21:
URL: https://github.com/apache/buildstream-plugins/pull/21#issuecomment-1200372306
As we release buildstream-plugins with buildstream, the same rules should apply to both repos.
We have declared API stability [since 1.95.0](https://lists.apache.org/thread/fm5sob2r93vrcgocg0k1lzz60kfoc63h), and this proposed change is clearly a break.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] nanonyme commented on pull request #21: Use build-dir by default
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #21:
URL: https://github.com/apache/buildstream-plugins/pull/21#issuecomment-1200375521
@gtristan interesting. Seems no one told this to @jjardon. https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/issues/1442 has been opened four weeks ago about upstreaming content
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] nanonyme commented on a diff in pull request #21: Enable setting build-dir
Posted by GitBox <gi...@apache.org>.
nanonyme commented on code in PR #21:
URL: https://github.com/apache/buildstream-plugins/pull/21#discussion_r933953103
##########
src/buildstream_plugins/elements/autotools.yaml:
##########
@@ -93,20 +94,39 @@ config:
- |
%{autogen}
- |
- %{configure}
+ if [ -n "%{build-dir}" ]; then
+ mkdir %{build-dir}
+ pushd %{build-dir}
+ %{configure}
+ popd
+ else
+ %{configure}
+ fi
# Commands for building the software
#
build-commands:
- |
- %{make}
+ if [ -n "%{build-dir}" ]; then
+ pushd %{build-dir}
+ %{make}
+ popd
Review Comment:
Right, subshell strategy definitely works. What is iffy here is whether it would be cleaner to pre-create commands-subdir if it doesn't exist, run autogen in subshell in conf-root (where it normally has to be run) and tell consumer that they can set build-dir through `command-subdir: build-dir`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] nanonyme commented on pull request #21: Use build-dir by default
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #21:
URL: https://github.com/apache/buildstream-plugins/pull/21#issuecomment-1200376004
Is this still an API break if build-dir is not set by default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] gtristan commented on pull request #21: Enable setting build-dir
Posted by GitBox <gi...@apache.org>.
gtristan commented on PR #21:
URL: https://github.com/apache/buildstream-plugins/pull/21#issuecomment-1200459030
> I'm not sure if it's possible to avoid cache keys changing. It's at least super hard. Not integrating this change means though that downstreams end up overriding very large amount of the defaults to get sane behaviour.
I’m not sure I agree that srcdir == builddir for autotools is not a sane default, it is usually more likely to work. As I recall gnome started configuring jhbuild to use srcdir != builddir primary because it was a goal to make gnome modules work under that condition.
That said, it is certainly expected that users apply their own customizations for YAML configuration and/or use their own custom build element implementations, that’s one motivation for greatly reducing the project.conf defaults.
With the BuildStream 2.0 API we are definitely prioritizing our promise to not break cache keys, that comes at the obvious cost of never changing upstream plug-in default YAML configurations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] abderrahim commented on a diff in pull request #21: Use build-dir by default
Posted by GitBox <gi...@apache.org>.
abderrahim commented on code in PR #21:
URL: https://github.com/apache/buildstream-plugins/pull/21#discussion_r933944017
##########
src/buildstream_plugins/elements/autotools.yaml:
##########
@@ -93,20 +94,39 @@ config:
- |
%{autogen}
- |
- %{configure}
+ if [ -n "%{build-dir}" ]; then
+ mkdir %{build-dir}
+ pushd %{build-dir}
+ %{configure}
+ popd
+ else
+ %{configure}
+ fi
# Commands for building the software
#
build-commands:
- |
- %{make}
+ if [ -n "%{build-dir}" ]; then
+ pushd %{build-dir}
+ %{make}
+ popd
Review Comment:
Either way, it's better to use the `-C` switch with make instead of this dance
##########
src/buildstream_plugins/elements/autotools.yaml:
##########
@@ -93,20 +94,39 @@ config:
- |
%{autogen}
- |
- %{configure}
+ if [ -n "%{build-dir}" ]; then
+ mkdir %{build-dir}
+ pushd %{build-dir}
+ %{configure}
+ popd
+ else
+ %{configure}
+ fi
Review Comment:
I'm not sure if this is the best idea, maybe it's better to make `%{build-dir}` the working directory?
Either way, using `pushd`/`popd` is problematic, because it's not available in all shells (`dash` and `busybox` for instance don't have it). You can probably use `cd -` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] nanonyme commented on pull request #21: Enable setting build-dir
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #21:
URL: https://github.com/apache/buildstream-plugins/pull/21#issuecomment-1200442345
I'm not sure if it's possible to avoid cache keys changing. It's at least super hard. Not integrating this change means though that downstreams end up overriding very large amount of the defaults to get sane behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] nanonyme closed pull request #21: Enable setting build-dir
Posted by GitBox <gi...@apache.org>.
nanonyme closed pull request #21: Enable setting build-dir
URL: https://github.com/apache/buildstream-plugins/pull/21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] nanonyme commented on pull request #21: Enable setting build-dir
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #21:
URL: https://github.com/apache/buildstream-plugins/pull/21#issuecomment-1200460523
There are both projects that only build with build-dir and projects that refuse to work at all with build-dir. I would say it's a requirement autotools supports both modes without huge effort on downstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] gtristan commented on pull request #21: Use build-dir by default
Posted by GitBox <gi...@apache.org>.
gtristan commented on PR #21:
URL: https://github.com/apache/buildstream-plugins/pull/21#issuecomment-1200376102
> @gtristan interesting. Seems no one told this to @jjardon. https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/issues/1442 has been opened four weeks ago about upstreaming content.
I'm not tracking all of the issues which get filed in fdsdk so I wouldn't know.
That said we shouldn't be considering API breaking changing patches upstream anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream-plugins] nanonyme commented on pull request #21: Enable setting build-dir
Posted by GitBox <gi...@apache.org>.
nanonyme commented on PR #21:
URL: https://github.com/apache/buildstream-plugins/pull/21#issuecomment-1200384401
I reversed the defaults so build-dir is now *not* set unless requested downstream. It is expected to be enabled through project-wide defaults.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org