You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "vishalmore90 (via GitHub)" <gi...@apache.org> on 2026/07/07 09:18:49 UTC

[PR] docs: Clean up SQLAlchemy 1.4 legacy references and update remaining … [airflow]

vishalmore90 opened a new pull request, #69535:
URL: https://github.com/apache/airflow/pull/69535

   ### Context
   
   PR #69200 updated several SQLAlchemy documentation links from `en/14` (SQLAlchemy 1.4) to `en/20` (SQLAlchemy 2.0), reflecting that Airflow core now requires SQLAlchemy 2.0+.
   However, that PR:
   1. Missed updating the pooling documentation link in `config.yml`.
   2. Incorrectly updated a historical 1.4 changelog link in `set-up-database.rst` (where the `postgres://` scheme deprecation was introduced) to point to the `en/20` docs.
   3. Left behind outdated warning prose referring to "SQLAlchemy 1.4+" in the database setup guide, which is no longer relevant now that Airflow 3 requires SQLAlchemy 2.0+ exclusively.
   
   This PR addresses these omissions and the feedback from issue #69164.
   
   ### Verification
   
   - Run `breeze build-docs` (Docker environment not available locally, but the syntax, links, and anchors have been manually verified to resolve correctly).
   - Verified target URLs:
     - Reverted link: `https://docs.sqlalchemy.org/en/14/changelog/changelog_14.html#change-3687655465c25a39b968b4f5f6e9170b`
     - Updated link: `https://docs.sqlalchemy.org/en/20/core/pooling.html#disconnect-handling-pessimistic`
   
   ### Checklist
   
   - [x] Link to the issues/PRs: Closes #69164
   - [x] Documentation-only change (no newsfragment needed)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Clean up legacy SQLAlchemy references and update remaining doc links [airflow]

Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on PR #69535:
URL: https://github.com/apache/airflow/pull/69535#issuecomment-4916285116

   Static checks are failing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] docs: Clean up SQLAlchemy 1.4 legacy references and update remaining … [airflow]

Posted by "vishalmore90 (via GitHub)" <gi...@apache.org>.
vishalmore90 commented on PR #69535:
URL: https://github.com/apache/airflow/pull/69535#issuecomment-4906192626

   @vincbeck  The SQLAlchemy 2.0 documentation (en/20) still hosts the SQLAlchemy 1.4 changelogs at /en/20/changelog/changelog_14.html. 
   Since Airflow core now exclusively requires SQLAlchemy 2.0+, it  preferred to point all documentation links to the /en/20/ namespace so that users remain within the modern documentation layout and navigation context. I will revert this link to en/20.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Clean up legacy SQLAlchemy references and update remaining doc links [airflow]

Posted by "vishalmore90 (via GitHub)" <gi...@apache.org>.
vishalmore90 commented on PR #69535:
URL: https://github.com/apache/airflow/pull/69535#issuecomment-4916933205

   > Static checks are failing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] docs: Clean up SQLAlchemy 1.4 legacy references and update remaining … [airflow]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #69535:
URL: https://github.com/apache/airflow/pull/69535#issuecomment-4902193700

   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
   - Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
   Apache Airflow is a community-driven project and together we are making it better 🚀.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Clean up legacy SQLAlchemy references and update remaining doc links [airflow]

Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on code in PR #69535:
URL: https://github.com/apache/airflow/pull/69535#discussion_r3545542450


##########
airflow-core/.pre-commit-config.yaml:
##########
@@ -134,11 +134,16 @@ repos:
         require_serial: true
       - id: lint-json-schema
         name: Lint config_templates/config.yml
-        entry: ../scripts/ci/prek/lint_json_schema.py
+        entry: python ../scripts/ci/prek/lint_json_schema.py

Review Comment:
   Why we need Python here as Python defined as language. Do we have exception for this hook not working without it similar to others?



##########
chart/.pre-commit-config.yaml:
##########
@@ -97,12 +97,17 @@ repos:
         require_serial: true
       - id: lint-json-schema
         name: Lint chart/values.schema.json
-        entry: ../scripts/ci/prek/lint_json_schema.py
+        entry: python ../scripts/ci/prek/lint_json_schema.py

Review Comment:
   Same here and I think for all hooks :)



##########
log3.txt:
##########
@@ -0,0 +1,493 @@
+2026-07-08T15:24:26.106059Z DEBUG prek: 0.4.8 (cccc61bef 2026-07-04)

Review Comment:
   This as well please. Not a good practice to push the logs maybe snippets in PR description would be good if these wanted to be shared



##########
log2.txt:
##########
@@ -0,0 +1,445 @@
+2026-07-08T15:21:03.720432Z DEBUG prek: 0.4.8 (cccc61bef 2026-07-04)

Review Comment:
   This should be deleted



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Clean up legacy SQLAlchemy references and update remaining doc links [airflow]

Posted by "vishalmore90 (via GitHub)" <gi...@apache.org>.
vishalmore90 closed pull request #69535: Clean up legacy SQLAlchemy references and update remaining doc links
URL: https://github.com/apache/airflow/pull/69535


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] docs: Clean up SQLAlchemy 1.4 legacy references and update remaining … [airflow]

Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #69535:
URL: https://github.com/apache/airflow/pull/69535#discussion_r3537061053


##########
airflow-core/docs/howto/set-up-database.rst:
##########
@@ -195,7 +194,7 @@ in the Postgres documentation to learn more.
               )
       E       sqlalchemy.exc.NoSuchModuleError: Can't load plugin: sqlalchemy.dialects:postgres
 
-   Details in the `SQLAlchemy Changelog <https://docs.sqlalchemy.org/en/20/changelog/changelog_14.html#change-3687655465c25a39b968b4f5f6e9170b>`_.
+   Details in the `SQLAlchemy Changelog <https://docs.sqlalchemy.org/en/14/changelog/changelog_14.html#change-3687655465c25a39b968b4f5f6e9170b>`_.

Review Comment:
   Why the 1.4 changelog?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org