[GitHub] [spark] wypoon commented on pull request #29020: [SPARK-23431][CORE] Expose stage level peak executor metrics via REST API

[GitBox <gi...@apache.org>]

wypoon commented on pull request #29020:
URL: https://github.com/apache/spark/pull/29020#issuecomment-663794380


   In the PR description,
   
   "This PR proposes to expose the peak executor metrics at the stage level via the REST API (/applications/<application_id>/stages/ or /applications/<application_id>/stages/<stage_id>/<stage_attemp_id>)."
   
   there is a typo; "<stage_attemp_id>" should be "<stage_attempt_id>".
   
   It might be helpful to clarify that the peak values of executor metrics **for the stage** are shown for each stage in the first (/applications/<application_id>/stages/) and peak values of executor metrics **for each executor for the stage** are shown for the second /applications/<application_id>/stages/<stage_id>/<stage_attempt_id>).
   At least, this is my understanding of what is intended.
   Edwina's PR description has
   
   "Peak values for metrics are show for each stage. For executor summaries for each stage, the peak values per executor are also shown."
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org