[GitHub] [arrow] galipremsagar opened a new pull request #10257: Fix a cuda 11.2 compiler segfault

[GitBox <gi...@apache.org>]

galipremsagar opened a new pull request #10257:
URL: https://github.com/apache/arrow/pull/10257


   With the nvcc 11.2 compiler we have a segfault when we have a copy and move assignment operator : 
   ```
   using Impl::operator=;
   ``` 
   before a move-assignment operator:
   
    ```
   Variant& operator=(Variant&& other) noexcept {
     this->destroy();
     other.move_to(this);
     return *this;
   }
   ```
   
   A minimal repro :
   
   With a segfault : https://godbolt.org/z/h9eYv6zas
   
   Without a segfault : https://godbolt.org/z/oWhK5qPd8
   
   In this PR, as a workaround, we have essentially re-ordered the move-assignment of `Variant` before `using Impl::operator=;`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #10257: Fix a cuda 11.2 compiler segfault

[GitBox <gi...@apache.org>]

github-actions[bot] commented on pull request #10257:
URL: https://github.com/apache/arrow/pull/10257#issuecomment-833152939


   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
   
   Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename pull request title in the following format?
   
       ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou closed pull request #10257: ARROW-12663: [C++] Fix a cuda 11.2 compiler segfault

[GitBox <gi...@apache.org>]

pitrou closed pull request #10257:
URL: https://github.com/apache/arrow/pull/10257


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #10257: ARROW-12663 : [C++] Fix a cuda 11.2 compiler segfault

[GitBox <gi...@apache.org>]

github-actions[bot] commented on pull request #10257:
URL: https://github.com/apache/arrow/pull/10257#issuecomment-833155243


   https://issues.apache.org/jira/browse/ARROW-12663


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org