[jira] [Comment Edited] (OAK-8267) Limit number of values in 'nestedCugs' hidden property in NestedCugHook

["angela (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-8267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824179#comment-16824179 ] 

angela edited comment on OAK-8267 at 4/23/19 2:19 PM:
------------------------------------------------------

[~rma61870@adobe.com], what you are looking for is definitely not a bug. the feature has deliberately been designed the way it works today and as far as i know Adobe documentation explicitly mentions that this is not intended to be used on every single node/page/asset. will adjust type and priority accordingly as it is accurate from an Oak point of view.


was (Author: anchela):
[~rma61870@adobe.com], what you are looking for is definitely not a bug. the feature has deliberately been designed the way it works today and as far as i know Adobe documentation explicitly mentions that this is not intended to be used on every single node/page/asset. will adjust type and priority accordingly.

> Limit number of values in 'nestedCugs' hidden property in NestedCugHook
> -----------------------------------------------------------------------
>
>                 Key: OAK-8267
>                 URL: https://issues.apache.org/jira/browse/OAK-8267
>             Project: Jackrabbit Oak
>          Issue Type: Wish
>          Components: authorization-cug
>            Reporter: Tom Blackford
>            Priority: Minor
>
> The logic in NestedCugHook.addNestedCugPath maintains a hidden multivalue string property at /:nestedCugs (see [1]). 
> If a customer had many thousands of CUGs, this would result in many thousands of values on this string property which is unlikely to scale.
> From [~anchela]: 
> {quote}
>  the reason for storing it is performance optimization i.e. minimizing reading from nodes to see if they hold a cug if the intended usages is that there are few and most nodes don't have a cug. i wouldn't not want to remove the hidden property for that default use case. but we could for sure take a look to see if we could introduce a threshold similar to the one at the root node i.e. using a counter instead of maintaining the complete list and in addition drop the list altogether in that case....
> {quote}
> [1]
> https://github.com/apache/jackrabbit-oak/blob/073f2b5378cd198a9cb30eb1f57958fb805ce508/oak-authorization-cug/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/cug/impl/NestedCugHook.java#L79



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)