[jira] [Commented] (ARIES-822) Add support for Context.OBJECT_FACTORIES to jndi.core

["Keith Wong (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARIES-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509589#comment-13509589 ] 

Keith Wong commented on ARIES-822:
----------------------------------

In the change #1412097, I think the following should also be applied in order to have correct results for DirObject's:

{noformat}Index: src/main/java/org/apache/aries/jndi/DirObjectFactoryHelper.java
===================================================================
--- src/main/java/org/apache/aries/jndi/DirObjectFactoryHelper.java	(revision 1416796)
+++ src/main/java/org/apache/aries/jndi/DirObjectFactoryHelper.java	(working copy)
@@ -82,7 +82,7 @@
         // Added under Aries-822, with reference 
         // to https://www.osgi.org/bugzilla/show_bug.cgi?id=138 
         if (result == null || result == obj) {
-            result = getObjectInstanceViaContextDotObjectFactories(obj, name, nameCtx, environment);
+            result = getObjectInstanceViaContextDotObjectFactories(obj, name, nameCtx, environment, attrs);
         } 
         
         return (result == null) ? obj : result;
{noformat}
                
> Add support for Context.OBJECT_FACTORIES to jndi.core
> -----------------------------------------------------
>
>                 Key: ARIES-822
>                 URL: https://issues.apache.org/jira/browse/ARIES-822
>             Project: Aries
>          Issue Type: Improvement
>          Components: JNDI
>            Reporter: Mark Nuttall
>            Assignee: Mark Nuttall
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> To quote https://www.osgi.org/bugzilla/show_bug.cgi?id=138 :
> The algorithm presented in the OSGI Enterprise 4.2 Specification, section
> 126.4, "JNDI Provider Admin service" lists seven steps that are to be taken
> when converting a description object to a requested object. 
> A new step should be inserted before the current step 7, in which if
> javax.naming.Context.OBJECT_FACTORIES is set as an environment or system
> property, then its value should be handled as per the existing javadoc. This
> states:
> 'Constant that holds the name of the environment property for specifying the
> list of object factories to use. The value of the property should be a
> colon-separated list of the fully qualified class names of factory classes that
> will create an object given information about the object. This property may be
> specified in the environment, an applet parameter, a system property, or one or
> more resource files. The value of this constant is
> "java.naming.factory.object".'

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira